Ticket #7111 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Update Elwin

Reported by: Dereck Kachere Owned by: Dereck Kachere
Priority: major Milestone: Release 2.6
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Alex Buts

Description (last modified by Nick Draper) (diff)

Change code to include the elf workspace when saving.

Change GUI to add :

  • input box with label 'SE log name' with default 'sample'
  • Tick box with label 'Normalise to lowest Temperature'

Change History

comment:1 Changed 7 years ago by Dereck Kachere

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Dereck Kachere

refs #7111 Updates to code

Format for unit variable changed, eq1 and eq2's y-axis label changed, included elf WS in 'Save' routine and added section for normalising.

Changeset: 68c487b13f4b99e6b008c0ba986159cdede4bad2

comment:3 Changed 7 years ago by Dereck Kachere

refs #7111 GUI changes.

Can now use the new functionality through the interface.

Changeset: 9f70745156add72b3c675d197344a77b88c95c67

comment:4 Changed 7 years ago by Dereck Kachere

refs #7111 Updates to code

Format for unit variable changed, eq1 and eq2's y-axis label changed, included elf WS in 'Save' routine and added section for normalising.

Changeset: 68c487b13f4b99e6b008c0ba986159cdede4bad2

comment:5 Changed 7 years ago by Dereck Kachere

refs #7111 GUI changes.

Can now use the new functionality through the interface.

Changeset: 9f70745156add72b3c675d197344a77b88c95c67

comment:6 Changed 7 years ago by Dereck Kachere

refs #7111 Corrected slight error

Now parses string correctly.

Changeset: f94006381124104fe305a0b2230aac863e4e7e66

comment:7 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/7020_quantification_formfactor_switch' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:8 Changed 7 years ago by Dereck Kachere

Merge branch 'feature/7111_elwin_updates' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:9 Changed 7 years ago by Dereck Kachere

Merge branch 'feature/7111_elwin_updates' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:10 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/7020_quantification_formfactor_switch' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:11 Changed 7 years ago by Dereck Kachere

Merge branch 'feature/7111_elwin_updates' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:12 Changed 7 years ago by Dereck Kachere

Merge branch 'feature/7111_elwin_updates' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:13 Changed 7 years ago by Dereck Kachere

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester:

Use the attached files for testing.

  • Run Elwin as shown in the Examples wiki page; it is in Indirect Data Analysis.
  • Select all the files as input.
  • Select Plot Result and Run.

Make a note of where the highest elastic intensity begins how the eq1 workspace looks. Now repeat as above, except select the Normalise to Lowest Temperature option. This should result in a shift of the Elastic Intensity axis, resulting in the highest elastic intensity beginning at 1 instead of 0.16.

To test whether the elf workspace is now being saved, load the files and select the Save Result option before running. The elf workspace should appear in your save directory.

comment:14 Changed 7 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:15 Changed 7 years ago by Alex Buts

No files attached and I do not have file with a temperature dependence.

comment:16 Changed 7 years ago by Alex Buts

  • Status changed from verifying to closed

looks fine.

The question is if elwin should be default method for indirect reduction. Should the GUI just remember last used as for me it always come with elwin now?

Also field sample is questionable. As I understand, it is the only option now. If there are some list of options it should be list box selection from these options.

comment:17 Changed 7 years ago by Alex Buts

Merge remote-tracking branch 'origin/feature/7111_elwin_updates' into master

comment:18 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:19 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Indirect Inelastic
  • Description modified (diff)

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7957

Note: See TracTickets for help on using tickets.