Ticket #7112 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SNSPowderReduction fails to find correct vanadium run

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: critical Milestone: Release 2.5.3
Component: Mantid Keywords: PatchCandidate,Released
Cc: petersonpf@… Blocked By:
Blocking: Tester: Peter Peterson

Description (last modified by Wenduo Zhou) (diff)

Powgen run 14721 - 14723 were collected at different frequencies. And thus they have different vanadium runs (11480, 11438 and 11478). But SNSPowderReduction cannot load correct vanadium runs for 14722 and 14732 when all these three runs are reduced by one call to SNSPowderReduction.

Change History

comment:1 Changed 7 years ago by Wenduo Zhou

Add some debug output. Refs #7112.

Changeset: 5e73c62fab2bba4d5a5bbf395720ee54b942db81

comment:2 Changed 7 years ago by Wenduo Zhou

Fixed the problem. Refs #7112.

Changeset: 9881a585d2bd48245d8709433b1117bf0fecce3c

comment:3 Changed 7 years ago by Wenduo Zhou

Refactored the code. Refs #7112.

Changeset: c23b7f58d3d637f4a88d24b47cd1f4c85eab8d76

comment:4 Changed 7 years ago by Wenduo Zhou

Merge branch 'bugfix/7112_powder_redux' into develop

comment:5 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to accepted
  • Keywords PatchCandidate added
  • Description modified (diff)

comment:6 Changed 7 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

How to test

Run script below:

cal_file = "PG3_PAC_d12358_2013_01_23.cal" char_file = "PG3_characterization_2012_11_29-HR-mods.txt" savedir = YOUR_TEST_DIRECTORY

# reduce a series of runs SNSPowderReduction(

Instrument="PG3", RunNumber=[14721, 14722, 14723], #RunNumber=[14722], Extension="_event.nxs", PreserveEvents=True, #VanadiumNumber=-1, CalibrationFile=cal_file, CharacterizationRunsFile=char_file, LowResRef=15000, RemovePromptPulseWidth=50, Binning=-0.0004, BinInDspace=True, FilterBadPulses=False, SaveAs="gsas", OutputDirectory=savedir, NormalizeByCurrent=True, FinalDataUnits="dSpacing", Sum = False)

You should find that 3 vanadium runs will be loaded.

comment:7 Changed 7 years ago by Wenduo Zhou

Clean log output. Refs #7112.

Changeset: 9f5b5b2af7cc32bef43ddda5b44b2c904dc4a768

comment:8 Changed 7 years ago by Wenduo Zhou

Modified key of info dictionary. Refs #7112.

Changeset: bb138302293af99dfa3cceee5b10a590a58ecc8c

comment:9 Changed 7 years ago by Wenduo Zhou

Merge branch 'bugfix/7112_powder_redux' into develop

comment:10 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:11 Changed 7 years ago by Peter Peterson

This was branched from the ​v2.5 tag in ​bugfix/7112_powder_redux so merging into the release branch can be done directly. The branch should not be deleted until it is merged into master and the 2.5.3 release.

comment:12 Changed 7 years ago by Peter Peterson

Merge remote branch 'origin/bugfix/7112_powder_redux' into master

comment:13 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

This was done correctly. However, there are a ton of inappropriate print statements that need to be dealt with (#7150).

comment:14 Changed 7 years ago by Peter Peterson

This has been merged into ​release/2.5.x.

comment:15 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/7114_ModeratorTzeroLinear' into 6856_ConvertToDiffractionMDWS_v2

comment:16 Changed 7 years ago by Wenduo Zhou

Merge branch 'bugfix/7112_powder_redux' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:17 Changed 7 years ago by Wenduo Zhou

Merge branch 'bugfix/7112_powder_redux' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:18 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/7114_ModeratorTzeroLinear' into 6856_ConvertToDiffractionMDWS_v2

comment:19 Changed 7 years ago by Wenduo Zhou

Merge branch 'bugfix/7112_powder_redux' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:20 Changed 7 years ago by Wenduo Zhou

Merge branch 'bugfix/7112_powder_redux' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:21 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/7114_ModeratorTzeroLinear' into 7090_runpythonscript

comment:22 Changed 7 years ago by Nick Draper

  • Keywords PatchCandidate,Released added; PatchCandidate removed

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7958

Note: See TracTickets for help on using tickets.