Ticket #7561 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Direct: Convert To Energy interface is broken

Reported by: Martyn Gigg Owned by: Alex Buts
Priority: blocker Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

To reproduce:

  • Start the interface;
  • Select MARI as an instrument;
  • There will be an error about the wrong type of parameter.
  • In some situations there has been a crash

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Owner set to Martyn Gigg

comment:2 Changed 7 years ago by Alex Buts

  • Status changed from new to inprogress
  • Owner changed from Martyn Gigg to Alex Buts

comment:3 Changed 7 years ago by Alex Buts

refs #7561 fixed crush but the GUI still does not work.

Changeset: ab9bb3a79cb0f2aaa84669537e52b94534d23214

comment:4 Changed 7 years ago by Alex Buts

refs #7561 one more step to make the script working

but still not the final step -- init is missed somewhere.

Changeset: 165b5b8e72f58e5b136558a490d0d899e9906b9f

comment:5 Changed 7 years ago by Martyn Gigg

Use full instrument name when setting default.instrument

in DirectEnergyConversion. Refs #7561

Changeset: 5cfdffaa123eec9c6469f2d610b15f7d04fa9a86

comment:6 Changed 7 years ago by Alex Buts

refs #7561 arb units work but absolute have problem

Changeset: b8b44357836a338e969f4af30a214f2d3b14b228

comment:7 Changed 7 years ago by Alex Buts

refs #7561 Looks like everything works now

though how precise are results are absolutely different question

Changeset: 65c1694122073bc5ea64da5f98e7fd0408bc27bf

comment:8 Changed 7 years ago by Alex Buts

refs #7561 Minor changes introduced to deal with workspace pointer

problem. Do not fix this problem but left just in case (like formatting changes)

Changeset: 9f9677f120d1967d8bb88d6c990c13ab325707f9

comment:9 Changed 7 years ago by Alex Buts

refs #7561 added unit test for saving files

Changeset: 57b5efa18a3726b0bdecab9b1c83a60b434b9a8e

comment:10 Changed 7 years ago by Alex Buts

refs #7561 Allow multiple default save formats

Changeset: efaac821cd33fb11b1dd534eb5a82abd727f2bec

comment:11 Changed 7 years ago by Alex Buts

refs #7561 Hopefully fixed save issue

Changeset: ba86f86a2c2a6bf97186fcb470a37fb05f4aecb8

comment:12 Changed 7 years ago by Alex Buts

refs #7561 fixed save function of the interface

Changeset: 9c3dc0c0c02908cc7d6734dce7983fbe8ebe3e09

comment:13 Changed 7 years ago by Martyn Gigg

Fix C2E interface that reports it has caught an exception. Refs #7561

Changeset: 8b00b794f5d12533afe49ebab43ae13b6e69c2e9

comment:14 Changed 7 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

The interface may need a bit of loving care and a lot of enhancements and testing but all seems work one or another way.

comment:15 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:16 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/7561_Conv2EnergyInterface'

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8406

Note: See TracTickets for help on using tickets.