Ticket #7989 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add a use existing event workspace only button to SCD Event Data Reduction

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.0
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: #7991 Tester: Vickie Lynch

Description (last modified by Peter Peterson) (diff)

  • Add QMin to the GUI as outlined in #8117.
  • As the TOPAZ group is getting more into correcting their data, allow for the reduction gui to keep the event workspace, but overwrite the md. This should be checkbox under "Use Existing Event and MD workspaces."
  • Make resizing the window scale the GUI

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Description modified (diff)

I couldn't help myself when I did added the fields to the layout, I reworked the whole gui so it would be expandable. The ticket name change reflects that.

comment:2 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

Re #7989. Made loading the events optional.

Also redid the entire first tab's layout and added the Qmin option.

Changeset: d5b99ffc5204fd678638c73f17f684a12b3a7cab

comment:3 Changed 7 years ago by Peter Peterson

Re #7989. Improving layout a bit more.

Changeset: 700855367233926dd89a68ec2fa303f3ed7bc554

comment:4 Changed 7 years ago by Peter Peterson

Re #7989. Finally got the scrollpane working.

Changeset: 5edc80fe6a054dba74e003dafe6ef43655b75cb3

comment:5 Changed 7 years ago by Peter Peterson

Re #7989. Fixed up the layout of the Find Peaks tab.

Changeset: 50ee69c8025230946b18ca472a247706f554dfaa

comment:6 Changed 7 years ago by Peter Peterson

Re #7989. Fixed up the layout of the Find UB tab.

Changeset: e72236faab2960395cea8385ad2b80611707c2bf

comment:7 Changed 7 years ago by Peter Peterson

Re #7989. Fixed up the layout of the Choose Cell tab.

Changeset: 40ca12b15cf3f6c241a810b3b98be3545122f7df

comment:8 Changed 7 years ago by Peter Peterson

Re #7989. Fixed up the layout of the Change HKL tab.

Changeset: 135ab53fe9a7e5d3cbe31f99e2e6f76017b54842

comment:9 Changed 7 years ago by Peter Peterson

Re #7989. Fixed up the layout of the Integrate tab.

Changeset: c8d6316b8e45f559083cd0647117616c68265b30

comment:10 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Tester set to Vickie Lynch

This is on ​feature/7989_scd_dont_reload_data.

To test:

  • For the resizing, see that there are scrollbars that appear on every tab.
  • For the Qmin, try using it and not and look at what the difference is in the logs for Qmin
  • For not reloading data, try running the first tab with and without loading data and convert to md.

comment:11 Changed 7 years ago by Peter Peterson

  • Blocking 7991 added

comment:12 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying

comment:13 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

All the new features mentioned work. The Intensity and SigInt are wrong because of this warning:

Warning: used HKL coordinates for MD workspace, not CoordinatesToUse from input I have fixed this in ticket #8193, but have also added properties to the integrate tab which conflicts with these changes. Here is my explanation of why the integration is wrong: 

In testing #8193 changes, I found that the SCD Reduction interface does not
 run correctly with MantidPlotNightly.  ConvertToMD has changed since the
 last release so that if the workspace contains a UB matrix, the result is
 HKL coordinates.  As part of this ticket, I will add the
 Q3DFrames="Q_sample" property that fixes this.

comment:14 Changed 7 years ago by Vickie Lynch

Merge remote branch 'origin/feature/7989_scd_dont_reload_data'

Full changeset: ​2b0a4683fbda970fc9b799033be13b34174ac4d1

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8834

Note: See TracTickets for help on using tickets.