Enhance DataSelector with better validation options

[Samuel Jackson]

The data selector class could benefit from being having some additional methods such as:

• isValid() which returns true if we have a valid filename/workspace name we can use
• currentView() which returns information about what view (file or workspace) is currently selected.

[Samuel Jackson]

Refs #8140 Add methods to validate widget input and check state.

Changeset: 40906280c774977c25dc1d815f6d00b86233e793

[Samuel Jackson]

Refs #8140 Updated UserInputValidator to support widget

Also made use of added functions in Fury for testing.

Changeset: ae4516775b4de8055778e0910036ce836c6707a5

[Samuel Jackson]

To Tester:

I've added the additional methods to the DataSelector widget and added a method to UserInputValidator to support it. For testing I modified the code in the Fury tab on the IDA interface to use the new methods so run though and check this works. You should also do a code review.

Instructions for running Fury can be found here: http://www.mantidproject.org/Indirect:Indirect_Data_Analysis#Running_Fury

[Roman Tolchenov]

DataSelector::getCurrentView() breaks encapsulation and exposes too much of the class' internals. It's better to return either an emum member or a named constant. Is this method necessary?

UserInputValidator::checkDataSelectorIsValid() makes assumptions on the nature of the validation failure. UserInputValidator::checkMWRunFilesIsValid() method uses a better approach from my point of view.

[Samuel Jackson]

Refs #8140 Updated DataSelector with suggested changes.

Changeset: 01ce81fdc3794f1ca4f1c4af584d3bd4fe2fd062

[Samuel Jackson]

After a discussion with Roman, I've updated this ticket with his suggested changes. To Test: As above.

[Roman Tolchenov]

Merge remote-tracking branch 'origin/feature/8140_dataselector_validation_options'

Full changeset: ​a566b29fe0d881f9c403be1bd5e0b2daaf693e77

[Russell Taylor]

While auditing old, unmerged branches I've found that the last commit above (in comment:7) was not merged into master - the merge was made using the previous commit.

Should this commit be merged? If so, create a new ticket and a new branch and cherry-pick the commit over to the new branch.

[Samuel Jackson]

Yes that commit should have been merged. But a method on the widget has been deleted in that last commit and I think there are places which rely on it. Will create a new ticket to fix this.

[Samuel Jackson]

Ticket is #9007

[Samuel Jackson]

Refs #8140 Updated DataSelector with suggested changes.

Changeset: ab076abc89c3a57c80d63b2765d6dcaeb05d4eb8

[Stuart Campbell]

This ticket has been transferred to github issue ​8985