Ticket #8196 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

PyChop LET does not work on rutherford

Reported by: Alex Buts Owned by: Alex Buts
Priority: trivial Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Samuel Jackson

Description

It does not start as seems uses pqt command, which is not available on unix.

Change History

comment:1 Changed 7 years ago by Alex Buts

  • Status changed from new to inprogress

refs #8196 This should fix it

Changeset: 054f332b56a360b92d787250c055d998344d41a9

comment:2 Changed 7 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is trivial change related to not fully Mantid-supported code. I have tested change, it works on RHEL and does not any harm on Windows so tester should just mere it to master.

comment:3 Changed 7 years ago by Alex Buts

  • Summary changed from PyChop LED does not work on rutherford to PyChop LET does not work on rutherford

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from verify to reopened
  • Resolution fixed deleted

Failed code review.

We must not leave commented code in as a way of deleteing lines of code. No one will remember why it was done in the future. Actually delete the line if that is what you intended to do. You can always get it back from GIT if you need it in the future.

Re-submit with the line of code deleted.

comment:5 Changed 7 years ago by Alex Buts

  • Status changed from reopened to inprogress

refs #8196 Deleted offending command in UI

so auto-generated py file does not have it too.

Changeset: 7bbd0fe8445b11e809c648cf58f00b7a0b226126

comment:6 Changed 7 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

Checked on Rutherford and windows -- works fine.

comment:7 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:8 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8196_PyChopLET'

Full changeset: ​2e5167051aac2af8f0df08f4276330e7e00228ac

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9041

Note: See TracTickets for help on using tickets.