Ticket #8393 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[IDA] ConvFit and FuryFit - composite output

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.1
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By: #8314
Blocking: Tester: Jay Rainey

Description

Request from Spencer. Add the following parameters to both ConvFit and FuryFit: 

Fit(Function=func,InputWorkspace=inputWS,WorkspaceIndex=i+specMin,Output=fout,MaxIterations=0,
            OutputCompositeMembers=True, ConvolveMembers=True)

Attachments

osi95119_graphite002_iqt.nxs​ (629.6 KB) - added by Samuel Jackson 7 years ago.
File for testing.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Blocked By 8314 added

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8393 Add extra options to Fit functions.

Changeset: ee8c50668a27d2a183387e382f5f0290e4b2eed8

comment:3 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.1

comment:4 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test: Run through both the ConvFit and FuryFit interfaces and do a sequential fit and check that you get the following additional output:

  • ConvFit: The *_Result workspace(s) should contain an additional entry for LinearBackground and UserFunction
  • FuryFit: The *_Result workspace(s) should contain an additional entry for LinearBackground and Convolution

The attached *_iqt file can be used to run FuryFit. irs26176_graphite002_red and irs26173_graphite002_res from the system tests can be used as the input sample and resolution files for ConvFit.

Changed 7 years ago by Samuel Jackson

File for testing.

comment:5 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:6 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

I ran through both ConvFit & FuryFit using the suggested files with single and multiple fit types. The new parameters are output as expected.

comment:7 Changed 7 years ago by Jay Rainey

The code related to this ticket was in a branch with different number. I merged that into master & fixed the message in #8389.

Merge remote-tracking branch 'origin/feature/8389_composite_output_furyfit_and_convfit'

Full changeset: ​17811701eca90c7e8ccd7a7ba22c15fd4c4c3422

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9238

Note: See TracTickets for help on using tickets.