Ticket #8314 (closed: fixed)
[IDA] FuryFit: Cannot build function
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.1 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #8393 | Tester: | Gesner Passos |
Description (last modified by Samuel Jackson) (diff)
Running FuryFit with either 2 exponentials or 1 stretched exponential and one exponential results in the following error:
ValueError: Invalid value for property Function (Function) "name=LinearBackground,A0=0.178017611572,A1=0,ties=(A1=0);;ties=(f1.Intensity=1-f0.A0)": Error in input string to FunctionFactory name=LinearBackground,A0=0.178017611572,A1=0,ties=(A1=0);;ties=(f1.Intensity=1-f0.A0) at line 11 in '<Interface>' caused by line 671 in '/opt/Mantid/scripts/Inelastic/IndirectDataAnalysis.py' caused by line 624 in '/opt/Mantid/scripts/Inelastic/IndirectDataAnalysis.py' caused by line 185 in '/opt/Mantid/bin/mantid/simpleapi.py'
Change History
comment:3 Changed 7 years ago by Samuel Jackson
- Status changed from new to inprogress
Refs #8314 Added function strings for two exponentials.
Also re-factored some of the sequential fitting code.
Changeset: 99605a84657a6d9c6ee127b9e367639ae81c35f7
comment:4 Changed 7 years ago by Samuel Jackson
Should also add saving the _Result workspace. See ticket #8390.
comment:7 Changed 7 years ago by Samuel Jackson
Refs #8314 Added saving result workspace to file.
Changeset: 00e45ee444ca886be8f8a08ed654b727140ca267
comment:8 Changed 7 years ago by Samuel Jackson
Refs #8314 Added logs and cleaned up saving workspaces.
Changeset: 5c30e39079fe6b67c82c41a83ead3da75d884640
comment:9 Changed 7 years ago by Samuel Jackson
Ref #8314 Updating FuryFitSeq test results to match.
Changeset: cf956eab3574fca7b56d43c968ceeebb79ce48e1
comment:10 Changed 7 years ago by Samuel Jackson
Refs #8314 ramp up tolerance on furyfit tests.
Changeset: 74df33f765a132cd9171dcdd46dbe17190c56fe1
comment:11 Changed 7 years ago by Samuel Jackson
Refs #8314 Fix tolerance on Fury again.
Changeset: 92e4be6cd40da194a76b50744824132b9857a4ec
comment:12 Changed 7 years ago by Samuel Jackson
Revert "Ref #8314 Updating FuryFitSeq test results to match."
This reverts commit cf956eab3574fca7b56d43c968ceeebb79ce48e1.
Changeset: 200297c41eb8241fb0a14346f286ee4c8e1e805c
comment:13 Changed 7 years ago by Samuel Jackson
Refs #8314 Update reference results and put tolerance back.
Changeset: 08fb6b8b09f6f669ffda028178bb6631f2388865
comment:14 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
To Tester:
Running FuryFit sequentially with either two exponentials or 1 exponential and 1 stretched exponential should now work. Ensure that the system tests are passing and do a code review to check that the changes are appropriate.
Instructions for running FuryFit can be found here: http://www.mantidproject.org/Indirect:Indirect_Data_Analysis#Running_FuryFit
comment:15 Changed 7 years ago by Gesner Passos
- Status changed from verify to verifying
- Tester set to Gesner Passos
comment:16 Changed 7 years ago by Gesner Passos
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/8314_fury_fit_func_string'
Full changeset: f31c25ae2588f9f0d8ad56a6c250a12c1c584808
comment:17 Changed 7 years ago by Gesner Passos
Merge remote-tracking branch 'origin/bugfix/8314_fury_fit_func_string'
Full changeset: 31263c07f12134f1d4d70baff8b0ebacab2fcb6b
comment:18 Changed 7 years ago by Gesner Passos
The error has gone. It now process normally.
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9159
This would be best handled building the function on the C++ side (which works for one iteration of a fit) and then passing that function string to the python.