SANS2D GUI reduction

[Gesner Passos]

System test for Gui reduction

[Gesner Passos]

I was forced to switch off checking sample, but I've opened one ticket for this #8320.

[Gesner Passos]

re #8313: Adjust systemtest SANS2DReductionGUI

Ticket #8245 organized the return methods to not return all the variants for LOG and LIN.

Changeset: 4ed5a22c7739ddf2b0094e1d608d515b380974d8

[Gesner Passos]

re #8313: SANS2DReductionGUI code small organization

Changeset: 33246907c79f2cfb09412de052656ee7c2223903

[Gesner Passos]

re #8313: SANS Reduction and adding runs

this systemtest provides coverage for adding runs using the add runs tab, and also ensure that the resulting file can be reduced normally.

Changeset: 641f6814c625999ed2f37fd7ed326a1f1a7d3a78

[Gesner Passos]

re #8313: SANS searching centre coverage

this systemtest ensure that the automatic searching centre algorithm works for SANS2D data. It covers all the steps that is currently being used in the UI.

Changeset: b55e67558e7b78bf4b378d2a25387117e015a687

[Gesner Passos]

re #8313: blacklist files for loadlotsoffiles

Changeset: 5b3bfa9fb11572e3f2ecdbac45f6511d4ebec6f4

[Gesner Passos]

Tester:

I have created these systemtests that call and execute what is being currently executed through the ISIS SANS interface. It helps us to ensure that things will continue to work nicely as we will introduce the new LARMOR instrument. It does also extends our coverage, for example, the SANS2DReductionGUIAdded ensure that the result of the reduction is reasonable.

All theses tests have just one reference result. So, it also ensures that the results are the same no matter what path you take.

Your responsibility here is to check that the systemtests are good (code review) and that they improve things (personal judgment).

These tests have passed on all machines in the test of Thursday evening:

• ​http://download.mantidproject.org/jenkins/view/Develop%20Clean%20Builds%20and%20Tests/job/is_test_win7_develop/lastSuccessfulBuild/testReport/SystemTests/SANS2DReductionGUI/
• ​http://download.mantidproject.org/jenkins/view/Develop%20Clean%20Builds%20and%20Tests/job/is_test_win7_develop/lastSuccessfulBuild/testReport/SystemTests/SANS2DReductionGUIAdded/
• ​http://download.mantidproject.org/jenkins/view/Develop%20Clean%20Builds%20and%20Tests/job/is_test_win7_develop/lastSuccessfulBuild/testReport/SystemTests/SANS2DSearchCentreGUI/

[Peter Parker]

Merge remote-tracking branch 'origin/feature/8313_gui_reduction'

Full changeset: ​16c65e20e48e079eb59b8e76acec7d63553baefc

[Peter Parker]

The system tests do indeed give us more coverage, and they are passing on Jenkins. Closing this ticket.

The only thing I'd mention after doing the code review would be to state my personal preference of making things "data-driven" when invoking a method multiple times. I.e., this:

self.checkFloat(i.ReductionSingleton().a, 1.0)
self.checkFloat(i.ReductionSingleton().b, 2.0)
self.checkFloat(i.ReductionSingleton().c, 7.0)
...

Would become this:

red = i.ReductionSingleton()
float_test_values = [
  [red.a, 1.0],
  [red.b, 2.0],
  [red.c, 7.0],
  ...
]

for actual, expected in float_test_values:
  self.checkFloat(actual, expected)

This is something you've done for the "options" in the unit tests for #8341, and I like it. But anyway, it does add more lines and is just my personal preference!

[Peter Parker]

Though admittedly we'd lose a useful line number being printed if any of the checks failed...

[Martyn Gigg]

Blacklist MaskSANS2DReduction.txt & sans2d_reduction_gui_batch.txt

from LoadLotsOfFiles Refs #8313

Changeset: 509eb534d3016d01a6e131811e87f2113f917493

[Martyn Gigg]

Merge remote-tracking branch 'origin/feature/8313_gui_reduction'

Full changeset: ​07d6841d8020aa0c59c096907b36e90f3ed46878

[Peter Parker]

(In #8308) See updated ticket description, and ignore previous comment from Gesner.

[Stuart Campbell]

This ticket has been transferred to github issue ​9158