Ticket #8596 (closed: wontfix)

Opened 7 years ago

Last modified 5 years ago

SaveNexus not saving Table workspaces correctly

Reported by: Samuel Jackson Owned by: Karl Palmen
Priority: major Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Samuel Jackson

Description

I've noticed that saving a table workspace with a column defined as type float doesn't appear to get loaded back in (may not even be saved?). However, if I set the column type to be string it saves and loads it correctly.

The problem can be reproduced by running the following script:

fname = "/tmp/test.txt"

tableWs = CreateEmptyTableWorkspace(OutputWorkspace="Test")
tableWs.addColumn("str", "Name")
tableWs.addColumn("float", "Value")

tableWs.addRow(['Hello', 1.35])

SaveNexus(tableWs, fname)
Load(fname, OutputWorkspace="Test2")

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Summary changed from Table workspaces not saving correctly to Table workspaces not loading correctly

comment:2 Changed 7 years ago by Karl Palmen

HDFView shows that only one column is saved, so it is a fault with SaveNexus (rather than loadNexus).

comment:3 Changed 7 years ago by Karl Palmen

  • Summary changed from Table workspaces not loading correctly to SaveNexus not saving Table workspaces correctly

comment:4 Changed 7 years ago by Karl Palmen

  • Status changed from new to inprogress
  • Owner changed from Anyone to Karl Palmen

comment:5 Changed 7 years ago by Karl Palmen

  • Milestone changed from Backlog to Release 3.1

comment:6 Changed 7 years ago by Karl Palmen

It works if one uses 'double' instead of 'float'.

comment:7 Changed 7 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to wontfix

Only column types of string, integer or double are saved to Nexus. Tickets have been issued for the other types, including #8603 for float.

Documentation of Table Workspaces at http://www.mantidproject.org/Table_Workspaces has been modified to indicated this.

To test, run the example python script, ammended with double instead of float. Check that the non-support of float is clearly indicated in the above mentioned wiki page and ticket #8603 deals with the situation.

comment:8 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:9 Changed 7 years ago by Samuel Jackson

All the points in comment 7 are valid, but I'm wondering if there's any way we can at least output a warning in NexusFileIO to the user that columns are going to be skipped? If this isn't feasible then I'm happy to pass this ticket.

comment:10 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Discussed with Karl. We can have another ticket (#8799) to handle adding a warning for users.

Last edited 7 years ago by Samuel Jackson (previous) (diff)

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9440

Note: See TracTickets for help on using tickets.