Ticket #8799 (closed: fixed)
In SaveNexus, warn of attempt to save unsupported type in a TableWorkspace
| Reported by: | Karl Palmen | Owned by: | Federico M Pouzols |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Dan Nixon |
Description (last modified by Karl Palmen) (diff)
At present, TableWorkspace supports only string, int and double data types when saving to Nexus, but other data types such as float can be entered into a table workspace and saveNexus can't save them and gives no warning of failing to save them.
Make saveNexus give a warning when it fails to save such a type. Ensure the warning is not repeated many times if that type occurs many times in the table.
Change History
comment:2 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
bulk move to assigned at the into of the triage step
comment:3 Changed 6 years ago by Federico M Pouzols
- Owner set to Federico M Pouzols
- Status changed from assigned to inprogress
comment:5 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Resolution set to duplicate
This ticket seems to have become duplicate (do we have deprecated/superseded category?) after significant improvements to NexusFileIO.cpp were done as part of #10123. Saving of table workspaces into NeXus files (in NexusFileIO::writeNexusTableWorkspace) was indeed a bit limited, but in #10123 support for all the previously unsupported types has been added: float, uint, long64, size_t, bool, V3D.
To test: double-check that #10123 fixes this (there is no need for warnings, as all types are supported now). The tests done for #10123 should be enough evidence. Saving / loading different data types is directly tested in 'SaveNexusProcessedTest' and 'LoadNexusProcessedTest'.
comment:6 Changed 6 years ago by Dan Nixon
- Status changed from verify to verifying
- Tester set to Dan Nixon
