Ticket #8800 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add system tests for ConvFit

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.2
Component: Indirect Inelastic Keywords:
Cc: Blocked By: #8807
Blocking: Tester: Roman Tolchenov

Description

As far as I can see, we don't have a system test for ConvFit. For obvious reasons, we should.

Spencer suggests the following input for a reasonable fit: 

Sample: irs26176
Res: irs26173  Type: res
Fit: 1 Lor
Background: Fit flat
X-range: -0.5 to 0.5
A0: 0.
Amp: 4.0
FWHM: 0.04

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Blocked By 8807 added

Due to a making a commit to the wrong branch, ticket #8807 should be merged into master before #8800.

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8807 Add some system tests for ConvFit.

Changeset: d1b071c94d610c017b02166bdbd27da8a9a12a06

comment:3 Changed 7 years ago by Samuel Jackson

Refs #8800 Relax tolerance.

Changeset: ee4ac58acf4de31d4965222e82ffc4204489df3e

comment:4 Changed 7 years ago by Samuel Jackson

Refs #8803 Update tolerance levels.

Changeset: 3f86d2411dcdeec2b92172729b23e0017956f007

comment:5 Changed 7 years ago by Samuel Jackson

Refs #8800 Update with more accurate parameters for IRIS.

Changeset: 7f570371f0c825b10a10ddedd81ec662aac79035

comment:6 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

Note that the branch number is wrong on github: it should be #8800, but the branch has the number #8803 and can be found ​here

To Tester

It looks like the failing IRIS test passed over night, so this should be OK for verification. Check the new system tests are passing on all platforms. You can run it locally to double check if you wish. Then do a code inspection.

Last edited 7 years ago by Samuel Jackson (previous) (diff)

comment:7 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:8 Changed 7 years ago by Roman Tolchenov

Ran the tests locally on Win 7. Didn't find them among failed ones on the test servers.

comment:9 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:10 Changed 7 years ago by Roman Tolchenov

Merged branch feature/8803_convfit_system_tests into master

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9644

Note: See TracTickets for help on using tickets.