Ticket #8759 (closed: invalid)

Opened 7 years ago

Last modified 5 years ago

ConfirmQMainWindow contains low-level code

Reported by: Owen Arnold Owned by: Keith Brown
Priority: major Milestone: Release 3.2
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

The specialised QMainWindow contains code relating to determining if the table has been modified (via a flag), and then raising a confirmation dialog if it has been. This should all be handled inside the reflgui code-behind, even if it is necessary to determine that closing is happening in the reflwindow script. A object method something like def attempt_safe_close() could do all of this.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:2 Changed 7 years ago by Keith Brown

#9170 should cover this

comment:3 Changed 7 years ago by Keith Brown

  • Status changed from assigned to verify
  • Resolution set to invalid

comment:4 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:5 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed
  • Milestone changed from Backlog to Release 3.2

I tested #9170 and ConfirmQMainWindow is now gone and the layout in refl_gui.py is like the more standard approach using QMainWindow classes.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9603

Note: See TracTickets for help on using tickets.