Ticket #9217 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Some Logging messages not working with clang and libc++

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: major Milestone: Release 3.2
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description (last modified by Stuart Campbell) (diff)

This problem was spotted while trying to get Mantid compiling on OS X using clang and libc++.

There were 4 placesin MantidQt/API/src that wouldn't compile straight away. So I have commented them out and this ticket is here to remove these comments. 

InterfaceFactory (lines 32 and 92)
PythonRunner.cpp (lines 30 and 62)

I have marked these places with a FIXME: Ticket-9217

Change History

comment:1 Changed 7 years ago by Stuart Campbell

  • Description modified (diff)

comment:2 Changed 7 years ago by Stuart Campbell

Commented out in order to compile with clang/libc++ on OS X.

refs #7284 There is a ticket to try and fix this (refs #9217)

Changeset: 7c15227ca4291d0fc0ddc971733ae7224c273957

comment:3 Changed 7 years ago by Nick Draper

  • Owner set to Stuart Campbell
  • Status changed from new to assigned
  • Component changed from Framework to User Interface

comment:4 Changed 6 years ago by Stuart Campbell

  • Status changed from assigned to inprogress

comment:5 Changed 6 years ago by Stuart Campbell

Added log messages back in.

It was just missing an include. refs #9217

Changeset: f249ae65e1a8a2a90ca826fa6d17c9d1a55fb207

comment:6 Changed 6 years ago by Stuart Campbell

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Stuart Campbell

This basically follows on from #7284 so the test is basically to make sure the Xcode build still works with these changes in.

comment:8 Changed 6 years ago by Stuart Campbell

  • Milestone changed from Backlog to Release 3.2

comment:9 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:10 Changed 6 years ago by Stuart Campbell

Added <sstream> to includes. refs #9217

Changeset: 0b771d801d96cae9fd6c20bd088feac6aa095eb9

comment:11 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9217_clang_logging'

Full changeset: ​b8d7cda2656a3ac85519189dd5998b5dfc22dfe9

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10060

Note: See TracTickets for help on using tickets.