Ticket #9397 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

SNS Live Listener Regression

Reported by: Ross Miller Owned by: Ross Miller
Priority: blocker Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

If the ADARA data stream starts with a RunStatus packet of type "New Run", the listener thread will deadlock. This is likely to happen if the user selects the option to replay events from the beginning of the run.

This is a regression introduced with #7209.

Change History

comment:1 Changed 6 years ago by Russell Taylor

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Ross Miller

  • Status changed from assigned to inprogress

Fix a potential deadlock in the SNS Live Listener

In certain cases (most likely caused when the user asks the SMS to replay all data from the start of the current run), the listener could get into a deadlock trying to initialize the workspace. This fixes that issue.

Also, added some code to make sure we always initialize the workspace with the most recent data available.

Refs #9397

Changeset: 36f301b128b6ba21067b7a23001170062f7c97ad

comment:3 Changed 6 years ago by Ross Miller

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • type changed from enhancement to defect

comment:4 Changed 6 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:5 Changed 6 years ago by Russell Taylor

Hard to test this when no instruments are running....

comment:6 Changed 6 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/9397_live_listener_regression'

Full changeset: ​cac7727f313d29bf69160f7dc47ad6493161346e

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10240

Note: See TracTickets for help on using tickets.