Ticket #9398 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Test failures on Windows turn Jenkins builds to unstable instead of failed

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 3.2
Component: Tools Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

This is an inconsistency with the *nix builds, which will fail in this situation. I could see an argument for having them go all go yellow to distinguish them from build failures, but I think I prefer the higher impact of going red for test failures.

Change History

comment:1 Changed 6 years ago by Russell Taylor

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Russell Taylor

  • Status changed from assigned to inprogress

Re #9398. Exit script and fail build if a command fails.

This is specifically indended to exit and fail the build if a unit test fails. Currently the job continues and it's only the parsing of the unit test output that turns the build to unstable. We want it to fail in this situation.

Changeset: a1a739db691de6d36814fe2deb62d75f5c7ebf56

comment:3 Changed 6 years ago by Russell Taylor

Gave wrong ticket number:

Re #8398. Missed out check for failure on first ctest call.

Changeset: 3f097676f8bb9b9342c89175a657580b217b88c8

comment:4 Changed 6 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

I've been waiting for a test failure on Windows to confirm that this is working correctly - Alex has obliged: http://builds.mantidproject.org/job/develop_incremental/label=win7-build/228/

Note that the build is red; previously it would have been yellow.

comment:5 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9398_windows_jenkins_test_fail_builds'

Full changeset: 934be65d1cd54fa639e5d32e91553fc103ec8124

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10241

Note: See TracTickets for help on using tickets.