Ticket #9903 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Slow Unit Tests for Ricardo Leal

Reported by: Owen Arnold Owned by: Ricardo Leal
Priority: major Milestone: Release 3.3
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: #9905 Tester: John Hill

Description (last modified by Owen Arnold) (diff)

We have a number of slow running unit tests which we need to fix as part of the 3.3 maintenance window. We are targeting test suits than execute in > 2 seconds on our clean rhel6 build servers. For IO tests (Loading & Saving) we have applied a more generous threshold of > 5 seconds.

See the full list to see which tests have been assigned to you: http://www.mantidproject.org/images/2/2f/Slow_tests.xlsx_-_Sheet1.pdf

Criteria

  1. Test suits (each test class instance) should execute in < 1 second as a rough target
  2. As a corollary to the above, If the test suite contains lots of test methods aim for < 0.1 second per test method
  3. If for some reason you get the speed up the test below the target using the strategies listed below, you need to justify why when you close the ticket.

Guidelines/instructions to help

  1. Keep tests readable and improve code readability where possible. Unit tests are documentation.
  2. Do not delete test methods without good reason. We do not want to reduce test coverage
  3. Changing the algorithm code to improve speed is OK, but exercise caution. Add additional test coverage if it's not already good enough.
  4. Take test methods that are slow and involve IO, or are processor intensive and make them into system tests. Integration tests are not Unit tests.
  5. Most of the speed improvements will probably come from better selection of input data. Caching input data is also a good option.
  6. Create sub tickets for algorithms or groups of algorithms to help testability if you wish, but mark this ticket as the 'blocked' by each one.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Owner changed from Peter Peterson to Ricardo Leal
  • Status changed from new to assigned
  • Description modified (diff)
  • Summary changed from Slow Unit Tests for Peter Peterson (cloned) to Slow Unit Tests for Ricardo Leal

comment:2 Changed 6 years ago by Owen Arnold

  • Blocking 9905 added

comment:3 Changed 6 years ago by Ricardo Ferraz Leal

  • Status changed from assigned to inprogress

Re #9903 Renamed test. Moved files to right folder

Changeset: 09340a20f316f25711de23c109f5fe1937e10dcf

comment:4 Changed 6 years ago by Ricardo Ferraz Leal

Re #9903 Remove LoadILLAsciiTest. Moved to system tests.

Changeset: 0d1bdca2c3aca4a8698be9d59adc2449f7dac113

comment:5 Changed 6 years ago by Ricardo Leal

  • Status changed from inprogress to verify
  • Resolution set to fixed

Note:

Both systemtest and mantid repositories were changed!

The slow test was moved to the system tests.

comment:6 Changed 6 years ago by John Hill

  • Status changed from verify to verifying
  • Tester set to John Hill

comment:7 Changed 6 years ago by John Hill

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9903_Slow_Unit_Tests'

Full changeset: fc259803caae2887e26db7983411c87b7fe82a55

comment:8 Changed 6 years ago by John Hill

Merge remote-tracking branch 'origin/feature/9903_Slow_Unit_Tests'

Full changeset: b7f06e6023a9452f32847daff564981fb8119e02

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10745

Note: See TracTickets for help on using tickets.