POLDI chopper speed needs to be corrected after reading files

[Michael Wedel]

The way the rotation speed of the new chopper at POLDI is recorded sometimes leads to odd numbers (for example 4999.3 rpm, when 5000 rpm are set). For data analysis, the target speed should be used. In the future, a field will be added to the data file, but right now this is handled by rounding to the next plausible speed (all allowed speeds are multiples of 500).

I would like to add a check for the new log-entry and rounding behavior if that is not present (for old data files).

[Michael Wedel]

Refs #10090. POLDI chopper speed is rounded to next 500

Changeset: 90346ccf845fffa2037fcb7c84b94f9e8c227604

[Michael Wedel]

Refs #10090. Refactored chopper parameter loading process.

Changeset: bfe29296dba0120241d6d28a137689b451208ba0

[Michael Wedel]

Added block, because new system test in #9711 contains data that can be used for testing the new behavior.

[Michael Wedel]

Refs #10090. Added extractor for chopper speed target

As it turns out, the chopper speed target is stored as integer list, so the value needs to be converted.

Changeset: 439d93f5e2dfa2385eaf290f370c38714f6c0397

[Michael Wedel]

Refs #10090. Added POLDI definition 2014b

The instrument definition is required for the adjusted system test.

Changeset: 850bad74d936d454c8aca76b825150bd75d7c43f

[Michael Wedel]

Refs #10090. Forgot to remove debugging statement

Changeset: ff2489f078553b893ee381a5485ecc62fa1b3b8b

[Michael Wedel]

Refs #10090. Added new data file to system test

The system test for PoldiAutoCorrelation works now as well. Some of the checks were a bit too strict, so they were relaxed a bit. The most important check is that the slope is 1 - this stayed as it was.

Changeset: de5960e170e549c9d6a53b246073a427fa8bdda9

[Michael Wedel]

Refs #10090. Changed PoldiTruncateData.

As indicated in the comment in PoldiTruncateData, the chopper loading should have been replaced immediately after #9445, but since that did not cause problems with old data files, it was not necessary. Now it uses the code in PoldiInstrumentAdapter and PoldiTruncateData also works with new data files where the chopper speed is off.

Changeset: e8c1285630514b160392e25179bdf2b4ed919e92

[Michael Wedel]

Refs #10090. Disable entry in poldi.dic

In some POLDI data files the field with chopper rotation speed target information seems to have some problems. Disabling this field in poldi.dic disables the check for chopper speed matching the target, while the rest of the functionality is preserved.

Changeset: e8bb63218c52bb69268e88e9aa59bd4395f264e7

[Michael Wedel]

Refs #10090. Included another file in the analysis

The file was already there from #9711 and actually shows a chopper speed that's a little off.

Changeset: 2fea4f5e924ef3c3fa9a50469edde0e39960b4f6

[Michael Wedel]

Testing information

The correlation method implemented in PoldiAutoCorrelation only works correctly when the chopper timing is correct. If unit- and adjusted system test pass, everything should be okay.

For additional manual confirmation, PoldiAutoCorrelation logs information about the chopper rotation speed, so if you like you can set the log level to "Information" and run this script before and after the changes (Requires poldi2014n019881.hdf from systemtests/Data):

poldiRaw = LoadSINQFile(Filename = "poldi2014n019881.hdf", Instrument = "POLDI")
LoadInstrument(poldiRaw, InstrumentName = "POLDI")
poldiCorr = PoldiAutoCorrelation(poldiRaw)

In the output of PoldiAutoCorrelation there should be a line like this before applying the changes:

_Poldi -     Chopper speed:    10000.4 rpm

After applying the changes from this ticket the value is different:

_Poldi -     Chopper speed:    10000 rpm

[Michael Wedel]

Merge branch 'master' into feature/10090_correct_poldi_chopper_speed

Full changeset: ​99e931fa93348b2758e0117960a8ef08af52d622

[Dan Nixon]

Merge remote-tracking branch 'origin/feature/10090_correct_poldi_chopper_speed'

Full changeset: ​88e02bcfa644a41eb2d5ec30d0527ce5cf0609b5

[Dan Nixon]

Merge remote-tracking branch 'origin/feature/10090_correct_poldi_chopper_speed'

Full changeset: ​fc3b9e1a66096324ed12ffd0bde1a0b810b9422f

[Stuart Campbell]

This ticket has been transferred to github issue ​10932