Ticket #10096 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

LoadSassena has stopped sorting by Qvector modulus

Reported by: Jose Borreguero Owned by: Jose Borreguero
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By: #10105
Blocking: Tester: Vickie Lynch

Description


Attachments

ordering_fix.2.py (264 bytes) - added by Jose Borreguero 6 years ago.
ordering_fix.py (264 bytes) - added by Jose Borreguero 6 years ago.

Change History

comment:1 Changed 6 years ago by Jose Borreguero

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Jose Borreguero

  • Status changed from assigned to inprogress

Refs #10096 Fix load functions

Changeset: 2b88dec15f987cb98842a139479d35a1941faedf

comment:3 Changed 6 years ago by Jose Borreguero

Refs #10096 antisymmetric value for negative times

Changeset: 83f5cb2f03088ff6a02bda3a6054cb4b5c9fc0ea

Changed 6 years ago by Jose Borreguero

Changed 6 years ago by Jose Borreguero

comment:4 Changed 6 years ago by Jose Borreguero

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Jose Borreguero

  • Milestone changed from Backlog to Release 3.3

comment:6 Changed 6 years ago by Jose Borreguero

Notes to Tester:

  1. Download input file unordered.h5 (6.8MB) from

https://dl.dropboxusercontent.com/u/819826/unordered.h5

to /tmp/unordered.h5

  1. Download and run script ordering_fix.py
  2. Compare workspaces unordered_qvectors and ordered_qvectors: Show Data, then 'plot by bin' the first column
  3. Spectrum with index 74 in unordered_fqt.Re should become spectrum with index 37 in ordered_fqt.Re. Check it out

comment:7 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

There is a cppcheck warning in LoadSassena that needs to be fixed before closing the ticket.

comment:8 Changed 6 years ago by Jose Borreguero

  • Blocked By 10105 added

comment:9 Changed 6 years ago by Jose Borreguero

  • Status changed from reopened to inprogress

Refs #10096 Fix cppcheck warning

Changeset: f5a941c6552b2d4c37e388bb57ee9ea4e1d751d8

comment:10 Changed 6 years ago by Jose Borreguero

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 6 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:12 Changed 6 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/10096_Fix_LoadSassena_SortByQVectors'

Full changeset: 3aeb6bfd4f7470c01091540424c436f4077bd06e

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10938

Note: See TracTickets for help on using tickets.