Ticket #10097 (closed: fixed)
Calc Resolution Bug
Reported by: | Owen Arnold | Owned by: | Harry Jeffery |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.2.1 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Owen Arnold |
Description
Not sure how this has happened, but the gui contains a script that prevents it calculating the resolution column dq/q.
I get the following error message due to a type mismatch
File "/Users/spu92482/Documents/mantid/mantid/Code/Mantid/scripts/Interface/ui/reflectometer/refl_gui.py", line 1226, in calcRes resolution = math.atan((s1vg + s2vg) / (2 * (s2z - s1z))) * 180 / math.pi / th TypeError: unsupported operand type(s) for /: 'float' and 'str'
- Open the Relectometry GUI.
- Change the instrument selection to INTER
- Load the attached table.
- Download the INTER runs 13462, 13463 and 13464 from the data archive for INTER. Make sure these workspaces exist in a managed user directory location.
- Hit process, you'll get the error above.
Attachments
Change History
comment:3 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
Testing: Follow instructions in ticket. On failure, only a run workspace will be created. On success, several workspaces will be created.
comment:4 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:5 Changed 6 years ago by Peter Peterson
- Keywords PatchCandidate removed
- Milestone changed from Release 3.3 to Release 3.2.1
comment:6 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/10097_calc_resolution_bug'
Full changeset: 3153905c5371741c246dbf1e91e7ea87e784cfc7
comment:7 Changed 6 years ago by Owen Arnold
Fix is what I would expect it to be.
Bug is gone from the original test instructions.
comment:8 Changed 6 years ago by Martyn Gigg
Cherry-pick fixes from bugfix/10097_calc_resolution_bug into next
Changes:
Fix calc resolution bug.
Refs #10097. (cherry picked from commit 98f1327acf5f4101d2cd15e100242b25fd499e33)
Changeset: f8dec1522c29f27f2ff338b1cc3e3fba24f61caf