Ticket #10115 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

ReflectometryReductionOneAuto should accept a workspace in lambda

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: major Milestone: Release 3.3
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

ReflectometryReductionOneAuto and ReflectometryReductionOne are restricted that the InputWorkspace must be in units of TOF. It should also be acceptable to have input in units of lambda. If this is the case, you can skip over the all the correction steps prior to the division.

Ask Owen Arnold for more detail if needed.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Harry Jeffery

Add IvsLam input support to ReflectometryReductionOne.

Refs #10115.

Changeset: 59c411362ef0ff8076d8b188bbd2d1bd10c7d4fc

comment:4 Changed 6 years ago by Harry Jeffery

Fix small typo in ReflectometryReductionOne.

Refs #10115.

Changeset: db885d6b7b40fbafe5bf2fd499c5514d2f208e24

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

Testing

  • Verify all relevant unit tests and doc tests are passing.
  • Test ReflectometryReductionOneAuto behaves correctly with workspaces in units of TOF and Wavelength.

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to reopened
  • Resolution fixed deleted

Forgot to update some algorithm documentation.

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from reopened to inprogress

Update ReflectometryReductionOne documentation.

Refs #10115.

Changeset: 775ac8d752a5740e3163e509e023a60a2b20d2fa

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

Testing

See comment 5.

comment:9 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

Would be good to have it log a notification that the lambda conversions were being skipped, because the input workspace was already in wavelength units. I couldn't see such a notification in your changes.

comment:10 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:11 Changed 6 years ago by Harry Jeffery

  • Status changed from reopened to inprogress

Add notification when skipping lambda conversions.

Refs #10115.

Changeset: e2f8574e2f09f215fab13c7ea354f54b8ba46e8a

comment:12 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:13 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying

comment:14 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10115_reflectometry_reduction_one_auto_accept_lambda'

Full changeset: ​f8352f115526ab86b4ee5826a40a24b46f6e55b0

comment:15 Changed 6 years ago by Owen Arnold

Good. The following generates the same plot 

run = Load(Filename='INTER00013460.nxs')

IvsQ, IvsLamGenerated, thetaOut = ReflectometryReductionOneAuto(InputWorkspace=run, ThetaIn=0.7)

plotSpectrum(IvsLamGenerated,0)

IvsQ, IvsLam, thetaOut = ReflectometryReductionOneAuto(InputWorkspace=IvsLamGenerated, ThetaIn=0.7)

plotSpectrum(IvsLam, 0)

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10957

Note: See TracTickets for help on using tickets.