Ticket #10238 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add plot buttons to new ReflGui

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By: #10237, #10257, #10563
Blocking: Tester: Federico M Pouzols

Description

Should be similar to behaviour of old gui.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

  • Blocked By 10257 added

comment:3 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Harry Jeffery

  • Blocked By 10563 added

Blocked by documentation, as this would have to update the new documentation before it could be merged.

comment:5 Changed 6 years ago by Harry Jeffery

Refs #10238 Remove unneeded virtual keywords

These won't be inherted. They don't need to be virtual.

Changeset: 128ec77e01c7097c355cd77de454bda7dcc1fcfd

comment:6 Changed 6 years ago by Harry Jeffery

Refs #10238 Add plotWorkspaces method to QtReflMainView

Changeset: 899a6329b60e7070c6864d80fb8cc28d51d597c9

comment:7 Changed 6 years ago by Harry Jeffery

Refs #10238 Add plotting actions to Refl UI

Changeset: 2f54216cb0f600859b963c946f9ce458f6ae4ac6

comment:8 Changed 6 years ago by Harry Jeffery

Refs #10238 Implement plotting in Refl UI

Changeset: 9771db7e61322a68c64e683d8f64cd74f281001e

comment:9 Changed 6 years ago by Harry Jeffery

Refs #10238 Support multi-run rows for group plotting

Changeset: 67655d1970b77cedfffe48db8dca97b93dad7625

comment:10 Changed 6 years ago by Harry Jeffery

Refs #10238 Document new plot actions

Changeset: a737b066e19f479b43ae77bd9145ae89b858f460

comment:11 Changed 6 years ago by Harry Jeffery

Refs #10238 Don't attempt to plot non-existant workspaces

Changeset: d50604ea3d93eee1ae0f7fa6ee4f285a85af468d

comment:12 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

Testing

  • There should be two new plot buttons in the new Refl UI
    • Verify the documentation acknowledges and explains their existence and effect sufficiently
  • Verify unit tests are passing
  • Play with the plot buttons after processing some data
    • The plot rows button should generate one curve per row selected (that has been processed)
    • The plot groups button should generate one curve per group selected (that has been processed)
Last edited 6 years ago by Harry Jeffery (previous) (diff)

comment:13 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:14 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to reopened
  • Resolution fixed deleted

This seems to be working well, except for one detail:

  • The "plot groups" button doesn't work when the group has more than one run.

I did the following. With INTER as instrument, I add one row: run 7709, angle: 1. Hit process, it works, and I can happily use "plot row" and "plot group". Add a second row: run 13463, angle 0.5. Hit process. Works well and I can plot it as a row and as a group. The two rows have groups 0 and 1. If I change the first row group to 1, or if I change the second row group to 0, then "plot group" doesn't do anything. Using the "group selected" button doesn't seem to help. With more rows the behavior is similar: when you put more than one row in a group, then the "plot group" button stops working for those rows. The menu actions behave exactly the same as the buttons.

I can get multi-line plots with "plot rows" on multi-selections, but I cannot get multi-line plots with "plot group"

Everything else seems fine:

  • The buttons are well explained in the doc.
  • The plot selected rows works
  • It's well documented, the GUI elements come with tooltip and what's-this strings.
  • Unit tests pass.

So I'd guess this is just a minor issue somewhere in the code. Or I might be misunderstanding something. In such case the doc might need clarification.

comment:15 Changed 6 years ago by Harry Jeffery

  • Status changed from reopened to inprogress

Refs #10238 Warn when plotting unprocessed rows

Changeset: 34bff70ca9204b1b7e4635badf410ef9cb65f32f

comment:16 Changed 6 years ago by Harry Jeffery

Refs #10238 Test plotting warnings

Changeset: a8c85dad72b323251adbc6bf8f26e07485eb6809

comment:17 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

In that case, the reason plotting was not occurring was because the group had not been processed, so there wasn't a workspace to plot. The interface now shows a warning when this is the case, and explains how to the user how to fix it.

comment:18 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying

comment:19 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

Perfect. Now even lousy users like me will be guided to do things properly. It also comes with new mock GUI tests which pass.

comment:20 Changed 6 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/feature/10238_refl_ui_plot_actions'

Full changeset: e2584d4690d125e16d15dee447428a046a5f0643

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11080

Note: See TracTickets for help on using tickets.