Run numbers and workspace names

[Owen Arnold]

We want to ensure that the reflectometry gui can full process workspaces that are already in the ADS (workspace list), and are not named in a special way. Here's how I think we should do it:

• Allow users to put any name in the run number or transmission number columns. Providing the name corresponds to a key in the ADS, processing should complete.
• Users will want the final outputs to look like IvsQ_{run_number}, etc, as is currently done, even if the workspaces are called something else. We should support this as far as possible (see below).
• We can try to extract the run number from the logs, but there are some scenarios where the logs won't exist. Therefore, if the run number doesn't exist in the logs, and the entry in the cell is digits only (use a regex something like ^\d+$) that it corresponds to a run number. If neither of these work, then we should just continue on and use the original workspace name.

The other thing we should NOT do is change the default instrument when the user changes the instrument on the reflectometry GUI. The instrument set on the reflectometry gui should be saved and loaded from the qsettings. To load and to specify an instrument as part of the process see http://www.mantidproject.org/MultiFileLoading

[Harry Jeffery]

Refs #10239 Update workspace naming scheme

Changeset: 0ff52787a5298245052e48093aa5f258f4eb2f1a

[Harry Jeffery]

Refs #10239 Refactor processing

• loadRun has replaced fetchRun
• Algorithms are no longer run as children
• makeTransWSName has been removed

Changeset: 94c8ee28f306bd703188feb3844a2d58653976d5

[Harry Jeffery]

The following commit exists between comment 2 and 3. The ticket id in its commit message was mistyped.

Refs #10239 Add getRunNumber method

Changeset: ​https://github.com/mantidproject/mantid/commit/8494e1122fc84e04272a7e570867d51db6752910

[Harry Jeffery]

Refs #10239 Fix unhandled exception

When searching the run log for run_number the NotFoundError exception was not being caught.

This commit also makes false positives when detecting a run number less likely: mydata and mydata2 will no longer be interpretted as mydata and run number 2.

Changeset: 332ea20b3c01887478bc347a348472f554333332

[Harry Jeffery]

Refs #10239 Add unit test for new functionality

Changeset: ab985977e686c05c1322bc81fe163a1422778970

[Harry Jeffery]

Testing

• Inspect code
• Verify new unit test covers desired functionality and is passing
• Verify new behaviour manually:
  • Load INTER00013460 and INTER00013462 into the ADS under custom names.
  • Verify that the custom names can be used in place of run numbers for processing.
  • Verify that the output workspaces use the run numbers, irrespective of the input workspace names.
  • Delete the run_number entry from an input workspace's log using DeleteLog algorithm.
  • Verify the workspace name is used as a fallback for the unknown run number.

Branch: ​https://github.com/mantidproject/mantid/compare/feature/10239_refl_run_numbers

[Owen Arnold]

Merge remote-tracking branch 'origin/feature/10239_refl_run_numbers'

Full changeset: ​a9bf3c8e091d51934e6e5cc5e930506cca8faaf2

[Owen Arnold]

Merge remote-tracking branch 'origin/feature/10239_refl_run_numbers'

Full changeset: ​a9bf3c8e091d51934e6e5cc5e930506cca8faaf2

[Stuart Campbell]

This ticket has been transferred to github issue ​11081