Context Navigation

Ticket #10235 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Calculate Default Inputs in new refl_gui

Reported by:	Owen Arnold	Owned by:	Harry Jeffery
Priority:	major	Milestone:	Release 3.3
Component:	Reflectometry	Keywords:
Cc:		Blocked By:	#10223, #10239
Blocking:		Tester:	Owen Arnold

Description

In the 'Old' refl gui, the code-behind works hard to try to pre-populate all the options given minimum information. The new gui should work in the same way. You should be able to cross-compare functionality between the two.

Ensure that tests are added to verify that the presenter is commanding the view correctly pushing values onto the display if they need to be calculated.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

Blocked By 10239 added

comment:3 Changed 6 years ago by Harry Jeffery

Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Harry Jeffery

Refs #10235 Allow processing without transmission runs

Changeset: 55d5410789dbff4bf8c9dffb89d79b8aa1740290

comment:5 Changed 6 years ago by Harry Jeffery

Refs #10235 Autofill empty columns in Refl UI

Extract TwoTheta from the log when able.
Calculate DQQ using TwoTheta when able.

Changeset: 0e6598dc310d9d78f1e2102c07707f122cda3f2b

comment:6 Changed 6 years ago by Harry Jeffery

Refs #10235 Add unit test for Refl UI autofilling

Changeset: 0b757cd1ecc1b1ea703ceb943911efcfb8c4b2ef

comment:7 Changed 6 years ago by Harry Jeffery

Testing

Try processing runs with different combinations of not providing two theta, the transmission runs and dqq. In all combinations the new UI should Do The Right Thing™.
Verify new unit test is passing
Inspect code

Branch: https://github.com/mantidproject/mantid/compare/feature/10235_refl_ui_default_inputs

comment:8 Changed 6 years ago by Harry Jeffery

Status changed from inprogress to verify
Resolution set to fixed

comment:9 Changed 6 years ago by Owen Arnold

Status changed from verify to verifying
Tester set to Owen Arnold

comment:10 Changed 6 years ago by Owen Arnold

Good but missing qmin, qmax population. We should do the calculation in the the Presenter. I would suggest adding these calculations as static or free functions so that they can be unit tested. The proper fix will depend on http://trac.mantidproject.org/mantid/ticket/9880 being done.

comment:11 Changed 6 years ago by Owen Arnold

Status changed from verifying to reopened
Resolution fixed deleted

comment:12 Changed 6 years ago by Harry Jeffery

Status changed from reopened to inprogress

comment:13 Changed 6 years ago by Harry Jeffery

Refs #10235 Allow qmin/qmax to be ommitted

Implement new static method calcQRange for calculating Qmin/Qmax
Allow empty qmin/qmax columns in validation
Supply qmin/qmax programatically when needed

Changeset: 1bfcb2bcd6f9c5c6b36b00e32202db559b1fcc36

comment:14 Changed 6 years ago by Harry Jeffery

Refs #10235 Update autofill unit test

Changeset: 1b6c9d8e204b227379cbe6e84317c194dd70976e

comment:15 Changed 6 years ago by Harry Jeffery

Status changed from inprogress to verify
Resolution set to fixed

calcQRange's functionality is already tested by the autofill test, and a test for calcQRange would require processing an IvsQ workspace that could be passed to calcQRange. So until the unit tests are reworked to be light-weight it doesn't seem worth the slow down to duplicate test coverage.