Ticket #9880 (inprogress)

Opened 6 years ago

Last modified 5 years ago

Modify ConvertUnits to take detector table

Reported by: Peter Peterson Owned by: Stuart Campbell
Priority: major Milestone: Backlog
Component: Framework Keywords:
Cc: Blocked By: #9879
Blocking: Tester:

Description

Add an optional workspace with a detector table which will be used rather than the instrument geometry. The table is changing according to #9879.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Stuart Campbell

  • Status changed from assigned to inprogress

Added optional property for detector pars.

Just added declaration in init() method to pass in a TableWorkspace containing detector parameters.

refs #9880

Changeset: 264f30355dca3c61e110849f6b8c434e4343e31d

comment:3 Changed 6 years ago by Stuart Campbell

Added initial stub of test for using detector pars.

refs #9880

Changeset: 858416481cd901ff2d0e6e71990ed9f2aeeed902

comment:4 Changed 6 years ago by Stuart Campbell

Started to add logic to use detector pars from table.

refs #9880

Changeset: e174dacccd244dab782c38f19359dfec84e39d4c

comment:5 Changed 6 years ago by Stuart Campbell

Added logic to check for L1.

Added code to see if an L1 column is there in the detector pars workspace. Added unit test for with/without L1 refs #9880

Changeset: 654aa3299c631bfae1d238c3202658f2d96c9854

comment:6 Changed 6 years ago by Stuart Campbell

Initial working version that can use parameter workspace.

refs #9880

Changeset: 10ebdc6481ff008b9b51142885d9ce6da626c29f

comment:7 Changed 6 years ago by Stuart Campbell

Added simple unit test for parameter workspace.

refs #9880

Changeset: f4b627dc42def9015072a337afef657c19d7ea89

comment:8 Changed 6 years ago by Stuart Campbell

Remove redefining variable. refs #9880

Changeset: 1eb9f9568471cf9b1355450034ea23e8dc525e00

comment:9 Changed 6 years ago by Stuart Campbell

Just disabling new test to make sure its not causing problems.

refs #9880

Changeset: cf60838274783aa90eb895c1869ac98b09f36056

comment:10 Changed 6 years ago by Harry Jeffery

  • Blocking 10217 added

comment:11 Changed 6 years ago by Harry Jeffery

  • Blocking 10217 removed

comment:12 Changed 6 years ago by Nick Draper

Moved to the backlog at the code freeze of R3.3

comment:13 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.3 to Backlog

comment:14 Changed 6 years ago by Stuart Campbell

As this is causing some subtle problems with the current usage of ConvertUnits - which could be due to these changes or just the way a couple of tests are written.

But to be safe, I am going to create a new algorithm ConvertUnitsUsingDetectorTable() under ticket #10748.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10722

Note: See TracTickets for help on using tickets.