LoadEventNexus incorrect field sizes handling

[Ross Whitfield]

In the following bit of code, while it detects the incorrect field sizes and skips looking for pulse times, it still assigns a (zero) pulse time. After the data is loaded there is no way to know that the pulseTime is bad, unless you compare the pulseTime() to a zero DataAndTime.

Possible solution, if condition is True convert the events to WeightedNoTime.

    int numPulses = static_cast<int>(thisBankPulseTimes->numPulses);
    if (numPulses > static_cast<int>(event_index->size()))
    {
      alg->getLogger().warning() << "Entry " << entry_name << "'s event_index vector is smaller than the event_time_zero field. This is inconsistent, so we cannot find pulse times for this entry.\n";
      //This'll make the code skip looking for any pulse times.
      pulse_i = numPulses + 1;
    }

[Stuart Campbell]

This is a comment

[Stuart Campbell]

This ticket has been transferred to github issue ​11083