Context Navigation

Ticket #10301 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Change Refl UI scale column type to double

Reported by:	Harry Jeffery	Owned by:	Harry Jeffery
Priority:	major	Milestone:	Release 3.3
Component:	Reflectometry	Keywords:
Cc:		Blocked By:	#9473, #10302
Blocking:	#10364	Tester:	Owen Arnold

Description

By changing the type from string to double, we can guarantee it'll always have a valid value. The default value can be 1.00 which is no-op.

Change History

comment:1 Changed 6 years ago by Nick Draper

Owner set to Harry Jeffery
Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Harry Jeffery

Blocked By 10301 added

This is blocked by #10302 because the row management improvements will be updated by the changes for this ticket.

Last edited 6 years ago by Harry Jeffery (previous) (diff)

comment:4 Changed 6 years ago by Harry Jeffery

Blocked By 10302 added; 10301 removed

comment:5 Changed 6 years ago by Harry Jeffery

Blocking 10364 added

(In #10364) Added blocked by #10301 to ensure I complete that work first, rather than perform it in the midst of this and end up with nasty merge conflicts.

comment:6 Changed 6 years ago by Harry Jeffery

Refs #10301 Change Refl UI scale column type to double

Changeset: 7127f5ac56c4f9dee5764a55b28ab3c0d3c47026

comment:7 Changed 6 years ago by Harry Jeffery

Refs #10301 Fix broken unit tests

Changeset: 4235aedfaea94ac6adc86d0db87d0eedd176fa49

comment:8 Changed 6 years ago by Harry Jeffery

Status changed from inprogress to verify
Resolution set to fixed

Testing

Check that the scale column still works as expected
Check that LoadReflTBL and SaveReflTBL still work as expected

comment:9 Changed 6 years ago by Owen Arnold

Status changed from verify to verifying
Tester set to Owen Arnold

comment:10 Changed 6 years ago by Owen Arnold

Status changed from verifying to reopened
Resolution fixed deleted

I would prefer it if you also added the functionality to correctly apply the scaling as part of this ticket. Also, It's not good that this defaults to zero. Scale should appear as 1 unless otherwise overwritten.

comment:11 Changed 6 years ago by Harry Jeffery

Status changed from reopened to inprogress

comment:12 Changed 6 years ago by Harry Jeffery

Refs #10301 Scale column defaults to 1

Changeset: 591827cc531268920f3456a6d796540f2f99ae17

comment:13 Changed 6 years ago by Harry Jeffery

Refs #10301 Scale IvsQ workspaces using scale column

Changeset: 57ba4272082caaa1883cea3200a8f33257232cb9

comment:14 Changed 6 years ago by Harry Jeffery

Refs #10301 Generalise row insertion

Sidestep the unit test issue by providing an internal row insertion method that does not disturb the view. This method may also be useful in future if we want to provide insertBefore/insertAfter actions.

Changeset: 483560d35f487103ca215e349e75b9277d4abb97