Ticket #10302 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Improve row management in New Refl UI

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.3
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: #10237, #10301, #10364 Tester: Owen Arnold

Description

  • New rows should be appended, not prepended
  • New rows should be placed into a new stitching group
  • There should be a way to re-order rows

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned
  • Component changed from Framework to Reflectometry

comment:2 Changed 6 years ago by Harry Jeffery

  • Blocked By 10295 added

comment:3 Changed 6 years ago by Harry Jeffery

  • Blocked By 10295 removed

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:5 Changed 6 years ago by Harry Jeffery

Refs #10302 Add getUnusedGroup

Changeset: aa28f0c10170193745e9a396e4c8842a66c138d8

comment:6 Changed 6 years ago by Harry Jeffery

Refs #10302 Make inserted use new group ids

Changeset: 35c62efdb74b02cc00c51249e4d85b92860594d2

comment:7 Changed 6 years ago by Harry Jeffery

Refs #10302 Make add row append a single row

Changeset: 135922a02db4ff9e28626d1384ebc9d10b73af93

comment:8 Changed 6 years ago by Harry Jeffery

Refs #10302 Update unit tests

Changeset: f3f149088b3c5d9cadf6cc91ebddf61207e6484a

comment:9 Changed 6 years ago by Harry Jeffery

Refs #10302 Update indentation

Changeset: 305ad1484883c447f91ad38da0d44c5b827af872

comment:10 Changed 6 years ago by Harry Jeffery

Refs #10302 Merge indentation commit

This avoids conflicts with #10295.

Changeset: 1378d6c5745a558b2d96b7f602ca6692ed8c2ef8

comment:11 Changed 6 years ago by Harry Jeffery

  • Blocking 10301 added

comment:12 Changed 6 years ago by Harry Jeffery

Refs #10302 Allow Refl UI rows to be reordered

Changeset: 239d6c7ffb245aab73776b2171380aa22b208a2b

comment:13 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

Testing

  • Verify tests are passing
  • Inspect changes
  • Test adding rows
    • Verify new rows are inserted after the currently selected row(s)
    • If no rows are selected, verify new rows are placed at the end.
    • Verify new rows are assigned unique stitching groups.
  • Test reordering rows
    • Reorder rows by dragging the row id on the left hand header of the table. You should be able to arrange the rows arbitrarily.

Branch: ​https://github.com/mantidproject/mantid/compare/feature/10302_refl_ui_row_management

Last edited 6 years ago by Harry Jeffery (previous) (diff)

comment:14 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:15 Changed 6 years ago by Harry Jeffery

  • Blocking 10364 added

(In #10364) #10302 is causing some nasty merge conflicts. Waiting for that to pass testing so that it can be merged into this branch.

comment:16 Changed 6 years ago by Harry Jeffery

  • Blocking 10237 added

comment:17 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10302_refl_ui_row_management'

Full changeset: ​4506b413172bfd96ad2db3af18f7f64cf9dc623e

comment:18 Changed 6 years ago by Owen Arnold

Good. Passed. As a minor point, it would be nice if the row numbers were reset when a row was repositioned. Also, a tooltip informing that the row can be selected and dragged or some other information would be required. I'm not sure that users are going to know that this feature is available.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11144

Note: See TracTickets for help on using tickets.