Ticket #10335 (closed: fixed)
Should there be a "Recent files" entry in main app menu -> File
Reported by: | Federico M Pouzols | Owned by: | Federico M Pouzols |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.3 |
Component: | GUI | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Anders Markvardsen |
Description
There's a "Recent projects", but nothing for files. This would have actually been convenient for some tests I'm doing now. I'd be happy to take it myself.
Change History
comment:1 Changed 6 years ago by Federico M Pouzols
- Status changed from new to assigned
- Owner set to Federico M Pouzols
comment:2 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from assigned to inprogress
recent files menu added into the main app menu, re #10335
Changeset: 664d2da2bb5f0334802fdff2671b4959ddd1d3e9
comment:3 Changed 6 years ago by Federico Montesino Pouzols
no conflict in recent files menu, re #10335
Changeset: 82955d5825f99dfb48a5cfc8c3d9b1b87ad7b0e4
comment:4 Changed 6 years ago by Federico Montesino Pouzols
a bit shorter lines, re #10335
Changeset: c8ee45c5625d9517ad484c77eb604c91445ce7fa
comment:5 Changed 6 years ago by Federico Montesino Pouzols
no-conflict in recent files menu, re #10335
Changeset: 37e6efae537de758606ddd0b10366fca660a1d5e
comment:6 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
Right below File-> "Recent projects" there's now a "Recent files" menu with the typical functionality of a "Recent..." menu.
comment:7 Changed 6 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Milestone changed from Backlog to Release 3.3
- Tester set to Anders Markvardsen
comment:8 Changed 6 years ago by Anders Markvardsen
- Status changed from verifying to reopened
- Resolution fixed deleted
Federico please note:
From github.com:mantidproject/mantid
- [new branch] feature/10381_convfit_convole_option_save_in_logs -> origin
/feature/10381_convfit_convole_option_save_in_logs
x [deleted] (none) -> origin/feature/10301_refl_ui_scale_column_dou
ble
x [deleted] (none) -> origin/feature/10370_MergeMDFiles_memory_rese
rve
x [deleted] (none) -> origin/feature/10378_refl_ui_minor_improvemen
ts ERROR: Branch 'feature/10335_recent_files_in_main_app_menu' has not been fully m erged to develop, meaning it is not possible to know whether the code is valid on all environments .
Contact Federico Montesino Pouzols on federico.montesino-pouzols@… (or via skype) and ask them to merge the code to develop using 'git checkbuild' from their branch feature/10335_recent_files_i n_main_app_menu and let you know when
Please also update: http://www.mantidproject.org/MantidPlot:_The_File_Menu
comment:9 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from reopened to inprogress
updateRecentFiles when loading new files removed from here, re #10335
also improved some error messages
Changeset: 642f35743a21a5f467725895c8863c6e9a581262
comment:10 Changed 6 years ago by Federico Montesino Pouzols
update recent files list from LoadDialog's accept, re #10335
Changeset: 1225561e7bed336575ad17244263183d86c909f6
comment:11 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
In principle it works reliably. You can for example test the following:
- You open a file, close it, remove it on disk or move it somewhere else, and try to open it from the recent files list. It should show a pop up with error message.
- If you open a file from the workspaces window (menu Load->File and context menu->File), it's also added into the recent files list.
- if you save a file (File->Save->Nexus), it's also added to the list.
I also updated the documentation: (http://www.mantidproject.org/MantidPlot:_The_File_Menu#File-.3E_Recent_Files).
I modified the code so that the list of recent files is updated whenever the "Load dialog" is run (accepted). This should catch any file data load, but please make sure there's no other places in the GUI that I might not be aware of where files would be loaded through a different procedure.
I couldn't do anything about the merge conflict that happened last week. Not sure where it was coming from but now it seems gone. It builds correctly in the integration servers. I just did the following.
$ git checkbuild
Produces:
Publishing branch 'feature/10335_recent_files_in_main_app_menu' git push origin feature/10335_recent_files_in_main_app_menu Everything up-to-date Deleting local copy of develop git branch -D develop Deleted branch develop (was e37b184). Creating local copy of develop git fetch -p From github.com:mantidproject/mantid x [deleted] (none) -> origin/feature/10215_clean_indirect_diffraction_ui x [deleted] (none) -> origin/feature/10282_create_scattering_function x [deleted] (none) -> origin/feature/10364_merge_refl_presenters remote: Counting objects: 413, done. remote: Compressing objects: 100% (394/394), done. remote: Total 413 (delta 278), reused 34 (delta 17) Receiving objects: 100% (413/413), 173.03 KiB | 0 bytes/s, done. Resolving deltas: 100% (278/278), done. * [new branch] bugfix/10388_iris_load_fmica_params_as_mica -> origin/bugfix/10388_iris_load_fmica_params_as_mica 7b8706d..613369e develop -> origin/develop 0ab1fff..ffd6edb feature/10194_save_nxtomo -> origin/feature/10194_save_nxtomo f841acf..62a2365 feature/10323_vesuvio_diffraction -> origin/feature/10323_vesuvio_diffraction f1a7939..a169128 feature/10365_slice_viewer_crash -> origin/feature/10365_slice_viewer_crash * [new branch] feature/10376_refl_ui_menu_bar -> origin/feature/10376_refl_ui_menu_bar 4f6f946..c2c4630 feature/10380_refl_ui_options_col_quote_commas -> origin/feature/10380_refl_ui_options_col_quote_commas * [new branch] feature/10391_moldyn_algorithm -> origin/feature/10391_moldyn_algorithm a09189e..dbd3882 feature/3878_partial_spectra_loading_event_nexus -> origin/feature/3878_partial_spectra_loading_event_nexus 6e6cf6e..6e0145f master -> origin/master git checkout develop Branch develop set up to track remote branch develop from origin. Switched to a new branch 'develop' git merge --no-ff feature/10335_recent_files_in_main_app_menu Auto-merging Code/Mantid/MantidPlot/src/Mantid/MantidUI.h Auto-merging Code/Mantid/MantidPlot/src/Mantid/MantidUI.cpp Auto-merging Code/Mantid/MantidPlot/src/ApplicationWindow.cpp Merge made by the 'recursive' strategy. Code/Mantid/MantidPlot/src/ApplicationWindow.cpp | 10 ++++------ Code/Mantid/MantidPlot/src/Mantid/MantidUI.cpp | 32 ++++++++++++++++++++++++++++++++ Code/Mantid/MantidPlot/src/Mantid/MantidUI.h | 4 ++++ 3 files changed, 40 insertions(+), 6 deletions(-) git push origin develop Counting objects: 10, done. Delta compression using up to 4 threads. Compressing objects: 100% (10/10), done. Writing objects: 100% (10/10), 1.55 KiB | 0 bytes/s, done. Total 10 (delta 9), reused 0 (delta 0) To git@github.com:mantidproject/mantid.git 613369e..2eb539a develop -> develop git checkout feature/10335_recent_files_in_main_app_menu Switched to branch 'feature/10335_recent_files_in_main_app_menu'
And then
$ git finish
produces:
git fetch -p git push origin feature/10335_recent_files_in_main_app_menu Everything up-to-date
comment:12 Changed 6 years ago by Federico Montesino Pouzols
small doxygen doc fix, re #10335
Changeset: c32f2d711aa7d645c08a0b3a04957bfdbc82b0be
comment:14 Changed 6 years ago by Anders Markvardsen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10335_recent_files_in_main_app_menu'
Full changeset: 5d6c99b85b824b4ae42a120fb6882790487e5dc9
comment:15 Changed 6 years ago by Anders Markvardsen
tested with a number of different types of files. documentation clear
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11177