Ticket #10343 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

delete macro HAS_UNORDERED_MAP_H

Reported by: Steven Hahn Owned by: Steven Hahn
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

The macro HAS_UNORDERED_MAP_H doesn't appear to be defined, leading to dead code and (potentially) degraded performance. Since all the supported platforms currently contain unordered_map, the fallback to std::map is no longer necessary.

Change History

comment:1 Changed 6 years ago by Steven Hahn

Refs #10343 Deleted macro, kept unordered unless it breaks a unit test

Changeset: e656a92e344b27c47c5424f1c2e91e532664434f

comment:2 Changed 6 years ago by Steven Hahn

Refs #10343. ParameterMap uses unordered_multimap

Changeset: f94f814ce5e1d89785aece20fa280c2963b94b40

comment:3 Changed 6 years ago by Steven Hahn

Refs #10343. formatting issue

Changeset: 263c0dba86411541ed9d13b5d4054ca39541cd2c

comment:4 Changed 6 years ago by Steven Hahn

With unordered_map, GroupDetectors2 does not pass all unit tests and the fix isn't obvious. I ran the performance tests before and after these changes. While the average with unordered_map is slightly faster, it's within the margin of error.

Before (seconds): [279.73, 278.22, 277.48, 277.36, 275.88], average = 277.7 pm 1.3 seconds

After (seconds): [274.11, 277.71, 275.63, 275.58, 274.08], average = 275.4 pm 1.3 seconds

comment:5 Changed 6 years ago by Steven Hahn

Refs #10343. Reinserted const to ComponentID

Changeset: 8df900e740217946d4b7fe9db4890839d92e7022

comment:6 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:7 Changed 6 years ago by Steven Hahn

For testing, I would suggest building mantid and verifying that all tests pass and that these changes don't create any new errors or warnings. One should also verify that there aren't any significant performance regressions.

comment:8 Changed 6 years ago by Steven Hahn

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:9 Changed 6 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:10 Changed 6 years ago by Steven Hahn

  • Status changed from verifying to closed

Merge branch 'master' into feature/10343_delete_macro_HAS_UNORDERED_MAP_H

Full changeset: fedbd17811b7cdc0b18fa720a252b519a00a9e85

comment:11 Changed 6 years ago by Pete Peterson

Merge remote-tracking branch 'origin/feature/10343_delete_macro_HAS_UNORDERED_MAP_H'

Full changeset: 4ff4f2ff4f6dd9898d84cb5beefc0294ae11dbbc

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11185

Note: See TracTickets for help on using tickets.