Ticket #10344 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add all 230 space group types into the factory

Reported by: Michael Wedel Owned by: Michael Wedel
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By: #10281, #10504
Blocking: Tester: Dan Nixon

Description

In ticket #10281 a factory for space groups was introduced, but only a few space groups were added for testing and demonstration purposes. In this ticket all 230 space group types should be registered into the factory.

The system test written for #10281 should cover this, it's mainly looking up the generators in the table.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Michael Wedel

  • Blocked By 10504 added

comment:3 Changed 6 years ago by Michael Wedel

  • Milestone changed from Release 3.3 to Release 3.4

comment:4 Changed 6 years ago by Michael Wedel

  • Milestone changed from Release 3.4 to Release 3.3

comment:5 Changed 6 years ago by Michael Wedel

  • Status changed from assigned to inprogress

Refs #10344. Checkpointing work

Changeset: 31d8d259f8704a266eb5a459160a097ac1fa2d9b

comment:6 Changed 6 years ago by Michael Wedel

Refs #10344. Completed space groups except cubic

Changeset: 6cfbbeb6597bc847534c36c63571c6c78d432fa8

comment:7 Changed 6 years ago by Michael Wedel

Refs #10344. Finished cubic space groups

Changeset: 707e76e4c049deb0a7fb308b86a472b53fe573cc

comment:8 Changed 6 years ago by Michael Wedel

Testing information

Make sure that the system test for SpaceGroupFactory passes.

comment:9 Changed 6 years ago by Michael Wedel

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:11 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10344_add_all_space_groups'

Full changeset: 72e8ac2c82c577de73a806f95bdc2bbdbce2e527

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11186

Note: See TracTickets for help on using tickets.