Ticket #10345 (closed: fixed)
Address remaining Coverity issues in MantidQt
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | GUI | Keywords: | |
Cc: | Blocked By: | #10368 | |
Blocking: | Tester: | Harry Jeffery |
Description
The majority of these are just uninitialized class members so should be relatively easy to fix.
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Fixed trivial issues, mainly uninitialised members
Refs #10345
Changeset: 6d06ffad61056c1bffa19239b2f6301c97461ff5
comment:4 Changed 6 years ago by Dan Nixon
Merge branch 'bugfix/10345_coverity_issues_in_mantidqt' into develop
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/JumpFit.cpp
Refs #10345
Changeset: 0e78dc1f7e0fff500e78271d6abdad0daf38d25a
comment:5 Changed 6 years ago by Dan Nixon
Correct initialisation order warnings
Refs #10345
Changeset: 44662859f69cac0f08c3e07538a0eb79d3a14613
comment:6 Changed 6 years ago by Dan Nixon
Fix copy paste error in FitPropertyBrowser
This seemed to be a genuine error which affects the automatic population of the X and Y columns in workspace settings group of fit properties.
Refs #10345
Changeset: 4a4e9565b1a3a6bdd755a9bc750b523e996334c8
comment:7 Changed 6 years ago by Dan Nixon
Merge branch 'master' into bugfix/10345_coverity_issues_in_mantidqt
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/JumpFit.cpp Code/Mantid/MantidQt/SpectrumViewer/src/SpectrumView.cpp
Refs #10345
Changeset: 868ebe08b6e53a046d0727048921854cdac82a2d
comment:8 Changed 6 years ago by Dan Nixon
Merge branch 'master' into bugfix/10345_coverity_issues_in_mantidqt
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReduction.cpp Code/Mantid/MantidQt/CustomInterfaces/src/JumpFit.cpp Code/Mantid/MantidQt/RefDetectorViewer/inc/MantidQtRefDetectorViewer/RefRangeHandler.h Code/Mantid/MantidQt/RefDetectorViewer/src/RefRangeHandler.cpp Code/Mantid/MantidQt/SpectrumViewer/src/GraphDisplay.cpp Code/Mantid/MantidQt/SpectrumViewer/src/RangeHandler.cpp Code/Mantid/MantidQt/SpectrumViewer/src/SpectrumDisplay.cpp Code/Mantid/MantidQt/SpectrumViewer/src/SpectrumView.cpp
Refs #10345
Changeset: 7ca79bef0f0c2fc42301bda8338d398327b9d2cd
comment:10 Changed 6 years ago by Dan Nixon
Merge branch 'master' into bugfix/10345_coverity_issues_in_mantidqt
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/MSDFit.cpp
Refs #10345
Changeset: ed5aced7ddb48828604af8e5502069bc71027c47
comment:11 Changed 6 years ago by Dan Nixon
Remove old variable from ApplyCorr constructor
Refs #10345
Changeset: a5659b188ef8436a465f1d7991f4846f7a9b7ff0
comment:12 Changed 6 years ago by Dan Nixon
To test:
- Review changes to ensure issues reported by Coverity have been addressed.
comment:13 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:14 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:15 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge branch 'master' into bugfix/10345_coverity_issues_in_mantidqt
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/JumpFit.cpp Code/Mantid/MantidQt/SpectrumViewer/src/SpectrumView.cpp
Refs #10345
Full changeset: 868ebe08b6e53a046d0727048921854cdac82a2d
comment:16 Changed 6 years ago by Dan Nixon
Merge branch 'master' into bugfix/10345_coverity_issues_in_mantidqt
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReduction.cpp Code/Mantid/MantidQt/CustomInterfaces/src/JumpFit.cpp Code/Mantid/MantidQt/RefDetectorViewer/inc/MantidQtRefDetectorViewer/RefRangeHandler.h Code/Mantid/MantidQt/RefDetectorViewer/src/RefRangeHandler.cpp Code/Mantid/MantidQt/SpectrumViewer/src/GraphDisplay.cpp Code/Mantid/MantidQt/SpectrumViewer/src/RangeHandler.cpp Code/Mantid/MantidQt/SpectrumViewer/src/SpectrumDisplay.cpp Code/Mantid/MantidQt/SpectrumViewer/src/SpectrumView.cpp
Refs #10345
Full changeset: 7ca79bef0f0c2fc42301bda8338d398327b9d2cd
comment:17 Changed 6 years ago by Dan Nixon
Merge branch 'master' into bugfix/10345_coverity_issues_in_mantidqt
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/MSDFit.cpp
Refs #10345
Full changeset: ed5aced7ddb48828604af8e5502069bc71027c47
comment:18 Changed 6 years ago by Harry Jeffery
Merge remote-tracking branch 'origin/bugfix/10345_coverity_issues_in_mantidqt'
Full changeset: 7988c268ac6e7e07c682729e52f5a04b6452607e
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11187