Context Navigation

Ticket #10408 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

AutoComplete tweaks

Reported by:	Owen Arnold	Owned by:	Harry Jeffery
Priority:	major	Milestone:	Release 3.3
Component:	Tools	Keywords:
Cc:		Blocked By:	#10348
Blocking:		Tester:	Owen Arnold

Description

The feature #10348 is very useful, and has been very well implemented but is lacking a couple of features.

You have a testable AlgorithmHintStrategy, but have implemented no testing for it
The pointer to the AlgorithmHintStrategy in the HintingLineEditFactory would best be held as a boost::scoped_ptr, it would give better exception safety and remove the need to write the destructor
Would be best if the tooltips stayed up while you were still editing the current key-value pair. On OSX then come up for a second and then disappear. Might not be possible, but would be good to extend the lifetime.

Change History

comment:1 Changed 6 years ago by Owen Arnold

The solution to the last point above, may be to use some sort of custom widget. Alternately, having a (?) button on the column heading for Options, that opened a panel listing all the key values would be a suitable solution.

comment:2 Changed 6 years ago by Harry Jeffery

Status changed from new to assigned

comment:3 Changed 6 years ago by Harry Jeffery

Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Harry Jeffery

Refs #10408 Use scoped_ptr in HintingLineEditFactory

Changeset: 773f8463e4d7b90e435db0ae98a0937d5fa98177

comment:5 Changed 6 years ago by Harry Jeffery

Refs #10408 Correct HintStrategy namespace

Changeset: 1cdc745a13c5ac0735bb4d3476d5fe0c4da9b9db

comment:6 Changed 6 years ago by Harry Jeffery

Refs #10408 Unit test AlgorithmHintStrategy

Changeset: 1a4efa51641147c493dbbd4ba1933f8ced12bc5e

comment:7 Changed 6 years ago by Harry Jeffery

Refs #10408 Fix the build

Changeset: 48d737a32abf8a77930277f3ea4ac3a2fe71d8f4

comment:8 Changed 6 years ago by Harry Jeffery

Refs #10408 Rework MantidWidgetsTest makefile

Changeset: e9f5645fa42b8d44a35950a4da331ed835c20c7d

comment:9 Changed 6 years ago by Harry Jeffery

Refs #10408 Add (Algorithm)HintStrategy to CMakeLists

Changeset: 56c6dc91f02242b657863eb3f913e10113cd9066

comment:10 Changed 6 years ago by Harry Jeffery

Refs #10408 GUITests depends upon MantidWidgetsTest

MantidWidgetsTest is now built as part of AllTests

Changeset: d1029b7cab1de3dc871cb0d8dfbe01d275a40d2a

comment:11 Changed 6 years ago by Harry Jeffery

Refs #10408 Tweak formatting of HintingLineEdit hints

Hint keywords are shown in bold and descriptions are placed upon their own line.

Changeset: 0dac5ef876644ca0f938531adce2cb5bb28d5ef2

comment:12 Changed 6 years ago by Harry Jeffery

Refs #10408 Remove run table tooltip

It suppresses the autocompletion tooltip in some cases.

Changeset: 524f81d1cee099b2870760683476e89ebf8f7ada

comment:13 Changed 6 years ago by Harry Jeffery

Refs #10408 Use QLabel to show hints

Instead of relying on QToolTip (which has problems on OSX), create a QLabel widget and style it to look like a tooltip.

Changeset: 9bc29d88e038352755718221b984f6aea40dd634

comment:14 Changed 6 years ago by Harry Jeffery

Status changed from inprogress to verify
Resolution set to fixed

Testing

Review the test for AlgorithmHintStrategy
- It should be passing
- It should make sense
Verify HintingLineEditFactory stores its reference to AlgorithmHintStrategy using a boost::scoped_ptr.
Verify the tooltip-esque hints for the HintingLineEdit remain visible for a reasonable amount of time
Review changes