Ticket #10409 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Replace ElWin code with ElasticWindow algorithm

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By: #10368
Blocking: #10492 Tester: Harry Jeffery

Description (last modified by Dan Nixon) (diff)

There is an algorithm that does the same routine as the UI so the UI may as well use it.

Attachments

irs26173_graphite002_sqw.nxs​ (158.2 KB) - added by Dan Nixon 6 years ago.
irs26176_graphite002_sqw.nxs​ (176.1 KB) - added by Dan Nixon 6 years ago.
IRIS00057871.log​ (47.0 KB) - added by Dan Nixon 6 years ago.
IRIS00057872.log​ (37.8 KB) - added by Dan Nixon 6 years ago.
irs57871_graphite002_red.nxs​ (405.0 KB) - added by Dan Nixon 6 years ago.
irs57872_graphite002_red.nxs​ (408.1 KB) - added by Dan Nixon 6 years ago.
osi92762_graphite002_red.nxs​ (1.1 MB) - added by Dan Nixon 6 years ago.
osi92763_graphite002_red.nxs​ (1.1 MB) - added by Dan Nixon 6 years ago.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:3 Changed 6 years ago by Dan Nixon

  • Blocked By 10368 added

Need an algorithm runner, added one in #10368.

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Added new ElasticWindowMultiple algorithm

Refs #10409

Changeset: 5318ec9fe9bebad609959e5aaf25c067b9dc8240

comment:5 Changed 6 years ago by Dan Nixon

Add ELF workspace and correct vertical units

Refs #10409

Changeset: 2f74e975cb11fc9fa2184b7365d0cfe2a5509fb5

comment:6 Changed 6 years ago by Dan Nixon

Support temperatures from log files

Refs #10409

Changeset: f103d7a6325903902e3f8c9383bd416c7224fc08

comment:7 Changed 6 years ago by Dan Nixon

Make changed to existing Elwin system test

Refs #10409

Changeset: dfed485a78c5301707669757e8fd58b057fc32d4

comment:8 Changed 6 years ago by Dan Nixon

Correct get temperature function

Refs #10409

Changeset: 75e00f78b38d04b932a7f3f26e047dc4c73e5b2e

comment:9 Changed 6 years ago by Dan Nixon

Work in progress adding new algo to existing UI

Refs #10409

Changeset: 5b34f4cb10698ca7c105ecb8cf4ac306714bc440

comment:10 Changed 6 years ago by Dan Nixon

Get workspace names from file names

Refs #10409

Changeset: 185888ef3f4ecd53f6717a991c5f4b927237d001

comment:11 Changed 6 years ago by Dan Nixon

Tidy UI, use naming required for MSD fit

Refs #10409

Changeset: 24fdf2c8a5bd90b6ce3a08a6f5b41ac902d2c467

comment:12 Changed 6 years ago by Dan Nixon

Fix failing unit tests

Refs #10409

Changeset: 49ca1c4e9db01e24382b2fd023845fdaa18a0bcb

comment:13 Changed 6 years ago by Dan Nixon

Fix failing system test

Refs #10409

Changeset: 36524d506889a09d5813cc836852d0dc550ee65a

comment:14 Changed 6 years ago by Dan Nixon

Use invisible workspaces in ElasticWindowMultiple

Refs #10409

Changeset: 1954a3b2f26fe990126f91c6936fab13950bc627

comment:15 Changed 6 years ago by Dan Nixon

Added ElasticWindowMultiple docs

Refs #10409

Changeset: 7dcdc9e861f5bb4a5dbefeadf34eb2ceb9cc01f5

comment:16 Changed 6 years ago by Dan Nixon

Added data and tests for ElWinMulti

Refs #10409

Changeset: 2baf8c8cf8836e7718271808ace258f595c18f15

comment:17 Changed 6 years ago by Dan Nixon

A few typo corrections

Refs #10409

Changeset: db6bc62a4b87370add42653f06363f7839d9a9bd

comment:18 Changed 6 years ago by Dan Nixon

Do not add mult marker to output WS

Refs #10409

Changeset: 7662852e82970b8eed29510c21728d1c0ce1efc3

Changed 6 years ago by Dan Nixon

Changed 6 years ago by Dan Nixon

Changed 6 years ago by Dan Nixon

Changed 6 years ago by Dan Nixon

Changed 6 years ago by Dan Nixon

Changed 6 years ago by Dan Nixon

Changed 6 years ago by Dan Nixon

Changed 6 years ago by Dan Nixon

comment:19 Changed 6 years ago by Dan Nixon

Note there are systemtest changes here: ​https://github.com/mantidproject/systemtests/compare/feature/10409_elwin_ui_use_elasticwindow

To test:

  • Ensure all system and doc tests are passing
  • Download the files attached to this ticket and put them somewhere Mantid will find them
  • Open Indirect > Data Analysis > Elwin
  • Select the two IRIS S(Q, w) files (S(Q, w) never worked on this interface before)
  • Enable plot result and Run
  • Should give the q, q2 and elf workspaces, elf x axis should be in run number
  • Select the two OSIRIS reduced files (temp is in log in files)
  • Enable Normalise to Lowest Temp
  • Enable plot result and Run
  • Should give q, q2, elf and elt workspaces, elf and etl x axis should be in temperature
  • Select the two IRIS reduced files (no temp. in files, should be loaded from log files)
  • Enable Normalise to Lowest Temp
  • Enable plot result and Run
  • Should give q, q2, elf and elt workspaces, elf and etl x axis should be in temperature

comment:20 Changed 6 years ago by Dan Nixon

  • Blocking 10492 added

comment:21 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:22 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:23 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10409_elwin_ui_use_elasticwindow'

Full changeset: ​7479c6d85f6176b91624547f8949f22632be1e98

comment:24 Changed 6 years ago by Harry Jeffery

Merge remote-tracking branch 'origin/feature/10409_elwin_ui_use_elasticwindow'

Full changeset: ​c9bf6ee16adddb5f2b38e1d047fce9e1ff476861

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11251

Note: See TracTickets for help on using tickets.