Context Navigation

Ticket #10440 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Refl UI should support copy/paste/clear operations

Reported by:	Harry Jeffery	Owned by:	Harry Jeffery
Priority:	minor	Milestone:	Release 3.3
Component:	Reflectometry	Keywords:
Cc:		Blocked By:	#10431
Blocking:	#10491	Tester:

Description

Users should be able to copy, paste, and clear rows. These should be provided as actions available from the menu bar and the right-click (context) menu.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

Blocked By 10431 added

comment:3 Changed 6 years ago by Harry Jeffery

Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Harry Jeffery

Refs #10440 Add clear row method

Changeset: 7a6b26b7daf4ba32e7d57483a1b2aa0a64a24ec1

comment:5 Changed 6 years ago by Harry Jeffery

Refs #10440 Add unit test for "Clear Selected" action

Changeset: 0acda03c070afb005196904a138f6b950e79e426

comment:6 Changed 6 years ago by Harry Jeffery

Refs #10440 Add "Copy Selection" action to Refl UI

Changeset: 06a38eb799c4d7c5f3cc4873761c424e39f74064

comment:7 Changed 6 years ago by Harry Jeffery

Refs #10440 Add "Paste Selected" action to Refl UI

Changeset: ed2c788626474de0d122970d04cc8dd7c760a5de

comment:8 Changed 6 years ago by Harry Jeffery

Refs #10440 Add "Cut Selected" action to Refl UI

Changeset: f55d72858f11066745b3c5c06624572dc6df4d08

comment:9 Changed 6 years ago by Harry Jeffery

Refs #10440 Use c++03 container iteration syntax

RHEL6 doesn't seem to support the new c++11 syntax

Changeset: 4b0e33d3ce5956ca2b2890b25c1f2d7465a49108

comment:10 Changed 6 years ago by Harry Jeffery

Status changed from inprogress to verify
Resolution set to fixed

Testing

"Clear selected" should clear the selected rows, setting their scale to 1 and ensuring the group is unique
"Copy selected" should copy the selected rows to the clipboard, with each row occupying its own line, and the cells delimited by tabs
"Cut selected" should behave the same as "copy selected", except that the selection is also removed from the table
"Paste selected" should do one of two things, depending on whether any rows are selected
- When no rows are selected, the clipboard's contents will be used to insert new rows at the bottom of the table
- If one or more rows are selected, the selected rows will be overwritten with the values from the clipboard. If there are more rows in the clipboard than selected, the extra rows will be ignored/discarded. If there are more rows selected than in the clipboard, the spare selected rows will be untouched.
Verify keyboard shortcuts for copy/cut/paste work (Ctrl-C/Ctrl-X/Ctrl-V on windows, Cmd-C/Cmd-X/Cmd-V on OS X)
Verify unit tests are passing
Inspect changes

Branch: https://github.com/mantidproject/mantid/compare/feature/10440_refl_ui_copy_paste_clear

comment:11 Changed 6 years ago by Harry Jeffery

Merge branch 'master' into feature/10440_refl_ui_copy_paste_clear

Refs #10440

Changeset: aa420b596a03ef29bbb415357ed157b6da7fb232

comment:12 Changed 6 years ago by Harry Jeffery

Refs #10440 Fix unit tests for ClearRows

Changeset: 6c66253ce254499eeb1a50823e40c2dd05c74437

comment:13 Changed 6 years ago by Harry Jeffery

Status changed from verify to reopened
Resolution fixed deleted

This can actually be done better. The clipboard should be read/written from QtReflMainView, when instructed by the presenter. This also provides an interface we can test it through.

Reopening.