Ticket #10491 (closed: fixed)
Change IReflPresenter flag type to enum
Reported by: | Harry Jeffery | Owned by: | Harry Jeffery |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | #10440 | |
Blocking: | Tester: | Owen Arnold |
Description
The flags are part of the IReflPresenter interface and so should be defined there, not in ReflMainView. They should also be an enum, not an int.
Change History
comment:3 Changed 6 years ago by Harry Jeffery
- Blocked By 10440 added
Waiting for #10440 to pass to prevent a merge conflict
comment:4 Changed 6 years ago by Harry Jeffery
Refs #10491 Change IReflPresenter flag type to enum
Changeset: 22e991a11988483b47728aa5ef0fe1f10da0664b
comment:5 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
comment:6 Changed 6 years ago by Harry Jeffery
Testing
There should be no behavioural changes.
- Verify build and unit tests pass
comment:7 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:8 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10491_ireflpresenter_flag_enum'
Full changeset: 7f2786df72d7aba41ec9fef4c92d57f5efc48e87
comment:9 Changed 6 years ago by Owen Arnold
Changes are consistent with the issue, and look sensible. The definitions should exist in the abstract type, and much better than using native ints. Tests are passing, and I used a version of the develop clean recently that used these changes, and all was fine.
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11333