Ticket #10457 (closed: fixed)
QtReflMainView clean up
Reported by: | Harry Jeffery | Owned by: | Harry Jeffery |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.3 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Dan Nixon |
Description
There's a few details in QtReflMainView that could be cleaned up, but individually are not substantial enough for a ticket:
- The QToolButtons could be replaced with a single QToolBar with actions specified in the UI file.
- The action handlers in QtReflMainView could be renamed to the form on_actionName_triggered() and Qt would automatically connect them for us.
- The progress bar could be initialised to 0 in the UI file instead of programmatically.
- "Group Rows" etcetera could be renamed to "Group Selected", for specificity.
Change History
comment:4 Changed 6 years ago by Harry Jeffery
Refs #10457 Connect actions automatically
Changeset: 3651eeac324831ea6bf4806ebfd6342ca236e7ac
comment:5 Changed 6 years ago by Harry Jeffery
Refs #10457 Zero out the progress bar declaratively
Changeset: 818c3f4717c26ce324eb134884971bbea1481a79
comment:6 Changed 6 years ago by Harry Jeffery
Refs #10457 Rename "Group Rows" to "Group Selected"
Changeset: 7cc1d8fe9c4a1a677c244e0431542a7a215a79d6
comment:7 Changed 6 years ago by Harry Jeffery
Refs #10457 Merge QToolButtons into a QToolBar
Changeset: 49e699c6c1b5a161058f557a4c0e128935c90d1b
comment:8 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
Testing
The only visible differences should be that the QToolButtons for changing the row will have been merged into a QToolBar, and "Group Rows" will now read, "Group Selected".
Everything else should be the same.
- Inspect changes
- Verify buttons in the toolbar work as expected
- Verify unit tests are passing
comment:9 Changed 6 years ago by Dan Nixon
- Status changed from verify to verifying
- Tester set to Dan Nixon
comment:10 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10457_qtreflmainview_clean_up'
Full changeset: f6177374993d6fc9ab68926f04fe2b9f0b10218a
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11299