Ticket #10542 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Allow a MolDyn function to be symmetrised without an instrument resolution

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

Currently a moldyn function in energy can only be symmetrised if the user supplies an instrument resolution to convolve with, it should be possible to do this without a resolution.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Add seperate symm option to MolDyn

Refs #10542

Changeset: 05d32673fbf069236509a4f74d43a40bd70d205b

comment:3 Changed 6 years ago by Dan Nixon

Fix issue with Symm that caused MolDyn to fail

Better unit testing for both

Refs #10542

Changeset: 817a95c3b4194b4632d023df860f910c066876bf

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • Verify unit (SymmetriseTest, MolDynTest) and doc (Symmetrise, MolDyn) tests are passing
  • Open Indirect > Simulation > MolDyn
  • Load sample file AutoTestData/UsageData/NaF_DISF.cdl
  • Enter function Sqw-total
  • Select Plot Result Spectra
  • Run in the following combinations, verify plot shape:
    • Crop Max Energy: Disabled, Symmetrise Energy: Disabled (positive x values only, max energy ~2.5)
    • Crop Max Energy: Disabled, Symmetrise Energy: Enabled (symmetric peak centred on 0, max energy ~2.5)
    • Crop Max Energy: 1.0 meV, Symmetrise Energy: Disabled (positive x values only, max energy ~1)
    • Crop Max Energy: 1.0 meV, Symmetrise Energy: Enabled (symmetric peak centred on 0, max energy ~1)

comment:5 Changed 6 years ago by Dan Nixon

Fix broken systemtest for ASCII import

Refs #10542

Changeset: 9b62615e9857de4dbbac923755c281efe5032e06

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10542_moldyn_symm_without_res'

Full changeset: ​25e199c450ce37ca5544db5ff21c5441d1d9c1e1

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11384

Note: See TracTickets for help on using tickets.