Ticket #10570 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Crash Running ReflectometryReductionOneAuto on OFFSPEC data

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: blocker Milestone: Release 3.3
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description (last modified by Harry Jeffery) (diff)

This is caused by fetching instrument parameters in an unsafe way.

We should:

  • Add a unit test to trigger this behaviour
  • Fetch instrument parameters in a failure tolerant way

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Summary changed from Crash Running ReflectometryReductionOne on OFFSPEC data to Crash Running ReflectometryReductionOneAuto on OFFSPEC data

Parameter XML file pending.

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned
  • Description modified (diff)

comment:3 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

Refs #10570 Add segfaulting test to ReflectometryReductionOneAutoTest

Changeset: 7dfef06baaf998e5ee20e70a663169ccd83aad79

comment:4 Changed 6 years ago by Harry Jeffery

Refs #10570 Sum range of point detectors

Changeset: ad9f36db421be98863d437e230d889bc1da009f0

comment:5 Changed 6 years ago by Harry Jeffery

Refs #10570 Fetch point detector parameters more carefully

Changeset: 4c7bb8687503d8f0042f13dc0924b9009aa0434a

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

Testing

  • Inspect changes
  • Verify unit tests and system tests are passing

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to reopened
  • Resolution fixed deleted

Doc tests failing

comment:8 Changed 6 years ago by Owen Arnold

Regarding ​https://github.com/mantidproject/mantid/commit/ad9f36db421be98863d437e230d889bc1da009f0

Could you please ensure that the documentation for the algorithm explains what is happening here. Could you add a unit test to ensure that that if the PointStartStop > 1, that you do indeed get double the signal in the final workspace. Also create a separate ticket to repeat this fix for CreateTransmissionWorkspaceAuto, which is probably doing exactly the same thing.

Finally, could you manually check with INTER, run 13460 (you can do this via your gui or the old one) that the output workspace is the same before and after this fix (it should be the same).

comment:9 Changed 6 years ago by Harry Jeffery

  • Status changed from reopened to inprogress

Revert "Refs #10570 Sum range of point detectors"

This reverts commit ad9f36db421be98863d437e230d889bc1da009f0.

Changeset: 53de00c25ba2f81de37e92db6684d1fa23d47d31

comment:10 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:12 Changed 6 years ago by Owen Arnold

All good. In the test cases, would be better to keep the workspaces out of the ADS, by creating the reflectometry algorithm an then setting child = True.

comment:13 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10570_crash_running_reflectometryreductiononeauto'

Full changeset: ​6863a1550bf7af3ebe07385d2da78f4d5af8711b

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11412

Note: See TracTickets for help on using tickets.