Ticket #10571 (closed: fixed)
Proper use of output properties in Indirect algorithms
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.3 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #10604 | Tester: | Federico M Pouzols |
Description (last modified by Dan Nixon) (diff)
Some of the workflow algorithms do not set output properties correctly, and as such do not report history.
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Summary changed from proper use of output properties in Indirect algorithms to Proper use of output properties in Indirect algorithms
comment:3 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Fixed issues in reduction, resolution and diff. reduction
Refs #10571
Changeset: 74cadc59789fdd4f0d6587f9dbe74f453b73a9bd
comment:4 Changed 6 years ago by Dan Nixon
Changed unit tests for algorithm changes
Refs #10571
Changeset: 6d81c8e700765864646aaa5192ade52e53817151
comment:5 Changed 6 years ago by Dan Nixon
Modify system tests to work with changes to algorithms
Refs #10571
Changeset: 6b5fa877b9d140d4f21201d43a0512da59445448
comment:7 Changed 6 years ago by Dan Nixon
- Priority changed from major to critical
- Description modified (diff)
comment:8 Changed 6 years ago by Dan Nixon
Note there are systemtest changes: https://github.com/mantidproject/systemtests/compare/bugfix/10571_indirect_algoritm_output_properties
To test:
- Run ensure all tests are passing
- Run Calibration:
- Run No 26173
- Save Enabled
- Run Energy Transfer:
- Run Files 27176
- Run Diagnostics:
- Input Files 26176
(using IRIS, graphite, 002)
comment:9 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:10 Changed 6 years ago by Dan Nixon
- Status changed from verify to reopened
- Resolution fixed deleted
comment:11 Changed 6 years ago by Dan Nixon
- Status changed from reopened to verify
- Resolution set to fixed
comment:13 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:14 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/10571_indirect_algoritm_output_properties'
Full changeset: 7716f1c5d9f035ef922e4550e106dc8492d4aacf
comment:15 Changed 6 years ago by Federico Montesino Pouzols
Merge remote-tracking branch 'origin/bugfix/10571_indirect_algoritm_output_properties'
Full changeset: 98f8d7f8f5af2935a0362704a346679c5963da49
comment:16 Changed 6 years ago by Federico M Pouzols
Works well. I can see the steps in the algorithm history of the workspaces being created: InelasticIndirectRecution, CreateCalibrationWorkspace, SaveNexus, TimeSlice, etc. Unit tests and Indirect system tests pass.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11413