Ticket #10572 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Improvements to style of Bilby loader

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: minor Milestone: Release 3.3
Component: SANS Keywords:
Cc: davidm@… Blocked By:
Blocking: Tester: Dan Nixon

Description

David writes:

The changes I made: Member variables of the BbyDetectorBankFactory class now begin with 'm_' . I also fixed a small bug in regards to masking BBY neutron event data during loading.

Change History

comment:1 Changed 6 years ago by Anders Markvardsen

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Anders Markvardsen

  • Status changed from assigned to inprogress

Improves to style loadbby. re #10572

Changeset: bfe6ca6178f2afe48016fe53bdd4cd8e58b141f1

comment:3 Changed 6 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester:

  1. from code review - check that you also accept style changes made by David

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10572_bilby_style_update'

Full changeset: ​e6d8932ae782c5d2687fee4bf4dcc1ce5a6ccc64

comment:6 Changed 6 years ago by Dan Nixon

Also ran relevant unit test locally.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11414

Note: See TracTickets for help on using tickets.