Ticket #10589 (closed: wontfix)

Opened 6 years ago

Last modified 5 years ago

Change EnginXCalibrateFull to use convertUnits

Reported by: Lottie Greenwood Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.5
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: #8368 Tester: Anders Markvardsen

Description (last modified by Lottie Greenwood) (diff)

EnginX Calibrate currently uses hard coded algorithm to translate from TOF to dSpacing. Change it to one already within Mantid.

For implementation - get all TOF values to store in vector and then create temporary workspace with those values to run convertUnit on, to then extract converted dSpacing values.

Change History

comment:1 Changed 6 years ago by Lottie Greenwood

  • Status changed from new to assigned
  • Description modified (diff)

comment:2 Changed 5 years ago by Lottie Greenwood

  • Owner changed from Lottie Greenwood to Federico M Pouzols

comment:3 Changed 5 years ago by Federico M Pouzols

  • Blocking 8368 added

(In #8368) Added new ENGIN-X tickets that have been opened in the last few months as 'blocked by'.

comment:4 Changed 5 years ago by Federico M Pouzols

It seems that this is propagated from EnginXFitPeaks (#10587)? There seems to be no obvious TOF->dSpacing conversion code in EnginXCalibrateFull.py itself.

comment:5 Changed 5 years ago by Federico M Pouzols

  • Status changed from assigned to verify
  • Resolution set to wontfix
  • Milestone changed from Backlog to Release 3.5

On more close investigation we saw that _getCalibratedDetPos() is converting from a GSAS parameter (difc) to L2, which is not covered by ConvertUnits algorithm.

Last edited 5 years ago by Federico M Pouzols (previous) (diff)

comment:6 Changed 5 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:7 Changed 5 years ago by Anders Markvardsen

  • Status changed from verifying to closed

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11431

Note: See TracTickets for help on using tickets.