Ticket #10611 (closed: fixed)
Calculate coverage for direct geometry
Reported by: | Andrei Savici | Owned by: | Andrei Savici |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.3 |
Component: | Direct Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #9105, #9304, #10698, #11222 | Tester: | Stuart Campbell |
Description
This will create an algorithm to calculate the exact coverage in reciprocal space for direct geometry measurements. It will be also the basis for MDNormDGS
Change History
comment:2 Changed 6 years ago by Andrei Savici
- Status changed from assigned to inprogress
Start work on DGS coverage. Refs #10611
Changeset: eb348e5de79d2bf1bfa061397ac5a637690faf47
comment:3 Changed 6 years ago by Andrei Savici
rst file. refs #10611
Changeset: afb124bd4296493bc9a17fcec6dec6e95c530f9b
comment:4 Changed 6 years ago by Andrei Savici
A few properties and calculations. Refs #10611
Changeset: 04f5d87b21060f33eded148044c673fa2950f4e5
comment:5 Changed 6 years ago by Andrei Savici
More input processing. Refs #10611
Changeset: fdffcb26234552a1bbf1d536626c464a725ad76f
comment:6 Changed 6 years ago by Andrei Savici
Use intersections to update coverage. Refs #10611
Changeset: 6cb9143082f1bfb782b516ec488aa20325639ccb
comment:7 Changed 6 years ago by Andrei Savici
Intersections with H planes. Refs #10611
Changeset: e628d664606944dfbf90850a082caa069a35e952
comment:8 Changed 6 years ago by Andrei Savici
Intersections with k and l planes. refs #10611
Changeset: 0369a4a46d772e13ed67fd20ab5109aad2d4bd87
comment:9 Changed 6 years ago by Andrei Savici
Test and documentation. Refs #10611
Changeset: cff9c73dc61806bb2fdaccc341d4969163d8498d
comment:10 Changed 6 years ago by Andrei Savici
Fix doctest. Refs #10611
Changeset: c8cf1d6d1e7c32c6c9cbe2e8f6af5be7541309cb
comment:11 Changed 6 years ago by Andrei Savici
Move constant from header to cpp. Refs #10611
Changeset: 48bbbdf5111a8dae39b89016a74461755fb5fdcd
comment:12 Changed 6 years ago by Andrei Savici
- Status changed from inprogress to verify
- Resolution set to fixed
To test: see usage example. Create a matrix workspace for a direct geometry instrument, that contains Ei, goniometer, and UB. Check if the output of CalculateCoverageDGS is consistent with what you get from ConvertToMD
comment:13 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from verify to verifying
- Tester set to Raquel Alvarez Banos
comment:14 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from verifying to reopened
- Resolution fixed deleted
Hi Andrei, I get this error when doing git test start, so I am reopening the ticket.
ERROR: Branch 'feature/10611_DGS_coverage' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments.
Contact Andrei Savici on saviciat@… (or via skype) and ask them to merge the code to develop using 'git checkbuild' from their branch feature/10611_DGS_coverage and let you know when it passes testing on the buildservers so you can start testing.
comment:15 Changed 6 years ago by Andrei Savici
- Status changed from reopened to verify
- Resolution set to fixed
comment:17 Changed 6 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester changed from Raquel Alvarez Banos to Stuart Campbell
comment:18 Changed 6 years ago by Stuart Campbell
- Blocking 10698 removed
There are merge conflicts with master that need to be fixed.
comment:21 Changed 6 years ago by Andrei Savici
Start work on DGS coverage. Refs #10611
Changeset: 3604fb4d77a95955369dbc3db282046894081aff
comment:22 Changed 6 years ago by Andrei Savici
rst file. refs #10611
Changeset: 56806d64b262724643b5e54b238bb20e8b9667bf
comment:23 Changed 6 years ago by Andrei Savici
A few properties and calculations. Refs #10611
Changeset: 53dad264ab24d9fc914e610b0b3faa5fbb188dda
comment:24 Changed 6 years ago by Andrei Savici
More input processing. Refs #10611
Changeset: 045cae6a30a86ac8fd5df5ea8499b38fc87ff547
comment:25 Changed 6 years ago by Andrei Savici
Use intersections to update coverage. Refs #10611
Changeset: d50882c92255d5d6bd80047bf05b6c05d45dd0de
comment:26 Changed 6 years ago by Andrei Savici
Intersections with H planes. Refs #10611
Changeset: 7f62314b2d756e30f1b3fd4e2285790de897d698
comment:27 Changed 6 years ago by Andrei Savici
Intersections with k and l planes. refs #10611
Changeset: b2ef2bf2b3e375b969f0d3aaa34bbd5c534e0386
comment:28 Changed 6 years ago by Andrei Savici
Test and documentation. Refs #10611
Changeset: 6e6110e1bc4a1f0612140df158eb783e9291a97a
comment:29 Changed 6 years ago by Andrei Savici
Fix doctest. Refs #10611
Changeset: 52d4afb8a87f28233b30cf98fa97cfc5c667b738
comment:30 Changed 6 years ago by Andrei Savici
Move constant from header to cpp. Refs #10611
Changeset: 4f9aa4a67daa53822e4fbe114058cfe3d95a241e
comment:31 Changed 6 years ago by Andrei Savici
Resolve conflict. Refs #10611
Changeset: 2864dd7359e2394999908a81cb53cc851f51b9b8
comment:32 Changed 6 years ago by Stuart Campbell
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10611_DGS_coverage'
Full changeset: 3a75e3422e22635898788d9d2bce1f72e35c2a52
comment:33 Changed 6 years ago by Peter Peterson
- Blocking 9304 added
comment:35 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11453
This could be used in #9304