Ticket #10698 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

MD normalization for direct geometry

Reported by: Andrei Savici Owned by: Andrei Savici
Priority: critical Milestone: Release 3.3
Component: Direct Inelastic Keywords:
Cc: Blocked By: #10611
Blocking: #9105 Tester: Alex Buts

Description

Use the trajectory calculation from #10611, and the MD normalization algorithm for diffraction to create MDNormDGS

Change History

comment:1 Changed 6 years ago by Andrei Savici

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Stuart Campbell

  • Blocked By 10611 removed

(In #10611) There are merge conflicts with master that need to be fixed.

comment:3 Changed 6 years ago by Stuart Campbell

  • Blocked By 10611 added

comment:4 Changed 6 years ago by Andrei Savici

  • Status changed from assigned to inprogress

Start working on MDNormDirectSC. Refs #10698

Changeset: da74966683e34160a95c9d4b2cd5c421d1bee4dd

comment:5 Changed 6 years ago by Andrei Savici

Get rid of calculateIntegrals. Refs #10698

Changeset: 59895582df02956e246ffa566adc830759746311

comment:6 Changed 6 years ago by Andrei Savici

Expose bin boundaries in Run. Refs #10698

Needed to check the original limits for energy transfer, in case they fall between the minimum and maximum of the MD workspace

Changeset: 0fd523459c8c72f3fd5cb4e917fa5f74f7a4dddd

comment:7 Changed 6 years ago by Andrei Savici

Minor change in dealing with other axes in MDNormSCD. Refs #10698

Changeset: 43c08891b11db36a0113233dab00b66178e389cf

comment:8 Changed 6 years ago by Andrei Savici

Finish dealing with inputs. Refs #10698

Changeset: 925b9785551281e9f58a25831175fcfc28f9cf69

comment:9 Changed 6 years ago by Andrei Savici

Finish DGS normalization for SC. Refs #10698

Changeset: 0b3ebc3699da04fe9bba863283d73fcd1df9d5aa

comment:10 Changed 6 years ago by Andrei Savici

Minor caching issues. Refs #10698

Changeset: 9e8bb4d28321c0f1b6511d3f8858e95b9a8aa799

comment:11 Changed 6 years ago by Andrei Savici

Documentation and test. Refs #10698

Changeset: 9520934f9c1e875547a63e31ba96e742185302a1

comment:12 Changed 6 years ago by Andrei Savici

  • Status changed from inprogress to verify
  • Resolution set to fixed

This ticket is an experimental feature, not easy to test. It should be done with someone familiar with direct geometry workflow. Here is the outline:

  • create a workspace2D for a direct geometry instrument, say using DGSReduction
  • set UB, goniometer
  • ConvertToMD in HKLE
  • Run MDNormDirectSC, the same way you run BinMD

There should be two output workspaces, one for binned data, one for normalization. Check if the normalization is non-zero wherever there is data. Look at the binned data in sliceviewer, with the NumberOfEventNormalization turned on. Divide binned data by the binned normalization. The output should be visualized with the NoNormalization option, and should look similar to the previous image. Note: there is no usage example. It will be done in ticket #10773

comment:13 Changed 6 years ago by Andrei Savici

Modify summary string. Refs #10698

Changeset: f32253481679a3bf5cb6f7edebd54c52d14c5926

comment:14 Changed 6 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:15 Changed 6 years ago by Pete Peterson

Re #10698. clang-format on the modified files.

Changeset: 88df701b2dfcbcadfbe9a93c9bc9fc2d2e41b0bf

comment:16 Changed 6 years ago by Alex Buts

  • Status changed from verifying to closed

There are a lot of questions to this algorithm both on local and global scale though the idea looks very interesting and promising.

I would reject this ticket in any other time, but because it is so close to release and main developer is not here, I am accepting this one and generating subsequent ticket to deal with later.

comment:17 Changed 6 years ago by Pete Peterson

Merge commit 'a826649797ea37bf70aa8a1aef238ed6be442ad2' into feature/10698_DGS_normalization

Full changeset: 6b5dff7eb294b2962332ec6419291df0874b6497

comment:18 Changed 6 years ago by Pete Peterson

Merge remote-tracking branch 'origin/master' into feature/10698_DGS_normalization

Conflicts:

Code/Mantid/Framework/API/inc/MantidAPI/Run.h Code/Mantid/Framework/API/src/Run.cpp Code/Mantid/Framework/MDAlgorithms/inc/MantidMDAlgorithms/CalculateCoverageDGS.h Code/Mantid/Framework/MDAlgorithms/src/MDNormSCD.cpp

Full changeset: 667723959ca78243abb06ca35af3539f261eceab

comment:19 Changed 6 years ago by Alex Buts

Merge remote-tracking branch 'origin/feature/10698_DGS_normalization'

Full changeset: 38219aae3f49acda8a74fbc5b0b9be16387a9aa8

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11540

Note: See TracTickets for help on using tickets.