Ticket #10626 (closed: fixed)
Use spectrum selection from Apply Corrections in other Indirect preview plots
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | spencer.howells@… | Blocked By: | #10492 |
Blocking: | Tester: | Harry Jeffery |
Description (last modified by Dan Nixon) (diff)
Out of all the preview plots that have been added th way the apply corrections one works is quite nice (i.e. using a spinner for spectrum selection and having a curve legend).
For IDA:
- For MSDFit, FuryFit, ConvFit:
- Change plot spectrum and spectra range to spinners
- Add a plot legend (black=sample, red=fit)
- For Elwin
- Add a combo box to allow the user to select an input workspace to preview
- Add a spinner allowing selection of the preview spectrum
For IDR:
- For Transmission:
- Add plot legend (black=can, red=sample, green=transmission)
- For Diagnostics and Calibration:
- Add raw plot spectrum selection (via property tree)
Attachments
Change History
comment:4 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Added spin boxes, elwin done, conv and fury work in progress
Refs #10626
Changeset: f43bff351ceec94f75a74a01b8bf9f97dcd461d4
comment:6 Changed 6 years ago by Dan Nixon
Range and preview spectrum selectors on IDA
Refs #10626
Changeset: d4bf294fcb4005adaab04fa7527f3e51a6a04069
comment:9 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10626_better_preview_plots_in_indirect_ui
Refs #10626
Changeset: 4d311681b0651a938825c3c079cad13af9760317
comment:11 Changed 6 years ago by Dan Nixon
Add plot legends to Indirect Data Analysis
Refs #10626
Changeset: 08e662481977c5b9a7d36882516e791c3a9bb1a6
comment:12 Changed 6 years ago by Dan Nixon
Add validation to single fit options
Refs #10626
Changeset: f34bc8edcd96abcf3fea78bf834a460a0e81c26a
Changed 6 years ago by Dan Nixon
- Attachment irs26173_graphite002_elwin_eq2.nxs added
Test file for MSD fit
Changed 6 years ago by Dan Nixon
- Attachment irs26176_graphite002_iqt.nxs added
Test file for Fury fit
comment:13 Changed 6 years ago by Dan Nixon
To test:
- For each fit interface (MSD, Fury, Conv) in IDA:
- With no file loaded click Fit Single Spectrum, this should give an error (this used to either do nothing or cause a crash)
- Load the sample files
- Switch the preview spectra using the Plot Spectrum spinner, this should be limited to the spectra range
- Change the fit range with the spectra range spinners, they should prevent min > max
- Set the parameters
- Click fit single spectrum, then change the preview spectra range, the fit curve should be removed (or reset for Fury)
- Run
- Verify the fitted range matches the spinners by the output workspace name
Data
- MSD: irs26173_graphite002_elwin_eq2.nxs
- Fury: irs26176_graphite002_iqt.nxs
- Conv
- Sample: irs26176_graphite002_red.nxs
- Res: irs26173_graphite002_res.nxs
Parameters
- MSD
- StartX: 0.8
- EndX: 2.5
- Fury
- EndX: 0.22
- (LinearBackground) A0: 0.03
- Conv
- Fit Type: Two Lorentzians
comment:14 Changed 6 years ago by Dan Nixon
Better error handling for preview plot updating
Refs #10626
Changeset: 517f8f9d0827eca95942953152253910e56a886e
comment:15 Changed 6 years ago by Dan Nixon
Disable spectra spin boxes by default
Refs #10626
Changeset: 705bfd917bd5dc41b4677bea81c6b5f72bb3f2b2
comment:16 Changed 6 years ago by Dan Nixon
Remove fit curve in MSD fit when changing spectra
Refs #10626
Changeset: 5c77a3c3f00596478912fbf014b4b2b131c37a71
comment:17 Changed 6 years ago by Dan Nixon
comment:18 Changed 6 years ago by Dan Nixon
Fix size of elwin UI preview options
Refs #10626
Changeset: c39aa88e7915a87a0c4ef46606f4e46091d87028
comment:19 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10626_better_preview_plots_in_indirect_ui
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/ConvFit.cpp Code/Mantid/MantidQt/CustomInterfaces/src/FuryFit.cpp
Refs #10626
Changeset: fd7615b1c53c6d87e21a080d8d1de5be761c0abf
comment:20 Changed 6 years ago by Dan Nixon
comment:21 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:22 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:23 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge branch 'master' into feature/10626_better_preview_plots_in_indirect_ui
Refs #10626
Full changeset: 4d311681b0651a938825c3c079cad13af9760317
comment:24 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10626_better_preview_plots_in_indirect_ui
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/ConvFit.cpp Code/Mantid/MantidQt/CustomInterfaces/src/FuryFit.cpp
Refs #10626
Full changeset: fd7615b1c53c6d87e21a080d8d1de5be761c0abf
comment:25 Changed 6 years ago by Harry Jeffery
Merge remote-tracking branch 'origin/feature/10626_better_preview_plots_in_indirect_ui'
Full changeset: b64ae9020d8d5012376cacca8cbd26850b231a66
comment:26 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11468