Ticket #10627 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Feature: VSI autoscale feature for custom color scaling and multiple workspaces.

Reported by: Anton Piccardo-Selg Owned by: Anton Piccardo-Selg
Priority: major Milestone: Release 3.4
Component: GUI Keywords: VATES
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

The color scaling inside the VSI is adapted to allow for custom color scaling behaviour. At first we implement an option to allow for a scaling of 10% of the max data and a log scale. This can be easily changed to make it technique-dependent for example. The color scaling feature also handles multiple workspaces and assesses the overall color scale with respect to the visibility of the workspaces.

Attachments

Test criteria for automatic color scaling.docx (17.7 KB) - added by Anton Piccardo-Selg 6 years ago.
MDHisto1.nxs (164.6 KB) - added by Anton Piccardo-Selg 6 years ago.
Test criteria for automatic color scaling (Updated).docx (18.6 KB) - added by Anton Piccardo-Selg 6 years ago.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Nick Draper

Moved to the backlog at the code freeze of R3.3

comment:3 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.3 to Backlog

comment:4 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from assigned to inprogress

Refs #10627 Adding custom auto color scaling for multiple workspaces

Changeset: 3b3d8e7e97f3592083becaeb21b69472a42638af

comment:5 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Adding functionality to auto color scaling in VSI

Changeset: 35325da1c54f1f82dc5efb289f3a5e874cfe38d9

comment:6 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Added range extraction from filters

Changeset: 180015e49016326eb97d1ec592e1e97328259cdd

comment:7 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Accounting for negative data in auto scaling

Changeset: 186f15c8467f9c42b6c48326b72fbf2d6175b423

comment:8 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Fix log scale bug

Changeset: 6977c7fcbc9a6dc1681603373a3b36f2eb0d3fdd

comment:9 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Fix the closing window bug

Changeset: fb30248c42f33052054692d2b5d9646a66e9a87a

comment:10 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Fix unit test empty data set in splatter plot

Changeset: 760c2e058ce4fc2f727ae93d0dcfc6035a080f13

comment:11 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Fix for qwt on linux and others

Changeset: 8e882012c27914e0fd4a5942a1d43ae1961a9582

comment:12 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Fix qwt dependency for plugins

Changeset: 73716f932fab77e99f259e9c0b83ad230da479b8

comment:13 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Fix error in Viewbase header

Changeset: 10c42df988065253cb263327c20b622fdb4b1bf0

comment:14 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Fix test for metadata extractor utils

Changeset: 7ddd451d95160422c27f7d3fcb7ede25e6b0188d

comment:15 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Fixing warnings

Changeset: 708e892b877e40ce9ca2e48ca9b4ba6959ced3f6

comment:16 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Fixing Json header files

Changeset: 128df8fcc9cd981c4181b3d144228505eef44060

comment:17 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Potential fix for makeFakeMDHistoWorkspace

Changeset: 63c3428675694617bc81c33c6741b1591142a065

comment:18 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Fix the doxygen warnings

Changeset: 49d396acafd46b76dde83a4c026da7abaf57d843

comment:19 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Further doxygen fixes

Changeset: 00fb1fbf05a3c19258d83d038e9a2d9b662c5c61

comment:20 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Fix for min and max value

Changeset: b0553b37ce4d369ca2ba33a41d692653fcb404b9

Changed 6 years ago by Anton Piccardo-Selg

Changed 6 years ago by Anton Piccardo-Selg

comment:21 Changed 6 years ago by Anton Piccardo-Selg

For Testing:

Please find the attached test instructions in the attachement as well as one of the sample workspaces. The other sample workspace is too large to attach. Please ask me for it and I will send it to you via email.

Please code review this

comment:22 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:23 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:24 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

A couple of things found:

  1. After entering invalid values into Minimum and Maximum fields they don't get corrected.
  2. In case of an error/warning a dialog should be shown and not a log window.
  3. Edit and Rescale buttons don't correlate with the toolbar controls.

comment:25 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from reopened to inprogress

Refs #10627 Check input values for min and max

Changeset: 29c2b33a5e709a7b58e0376d9891cfa2e63e5ca0

Changed 6 years ago by Anton Piccardo-Selg

comment:26 Changed 6 years ago by Anton Piccardo-Selg

For tester:

Regarding the discussed points:

  1. The values for minimum and maximum are now set to only allow minimum <= maximum. Simularly, one cannot have values <= 0 in log mode.
  2. The log window is not being displayed any longer as this was triggered by values<= 0 in log mode.
  3. It was decided to leave this as it is, as we intend to alter the properties panel when migrating to ParaView 4.3

An updated test script, reflecting the changes made, is attached ( Test criteria for automatic color scaling (Updated).docx). The test data stays the same.

comment:27 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:28 Changed 6 years ago by Anton Piccardo-Selg

Refs #10627 Fix merge conflict

Changeset: 5278bbadcbfa42dd45171273f2f010eb51a238fa

comment:29 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying

comment:30 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10627_auto_color_scale_vates'

Full changeset: e4390c4db7bb818d29ffa40fc826560644304a11

comment:31 Changed 6 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.4

moved to r 3.4 as tickets are closed

comment:32 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11469

Note: See TracTickets for help on using tickets.