Ticket #10708 (closed: fixed)
Update default instrument parameters from workspace
Reported by: | Alex Buts | Owned by: | Alex Buts |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.3 |
Component: | Direct Inelastic | Keywords: | |
Cc: | Blocked By: | #10681 | |
Blocking: | #10705 | Tester: | Lottie Greenwood |
Description (last modified by Alex Buts) (diff)
Bug identified while working with inelastic reduction (actually pretty old one)
Current reduction loads parameters from empty workspace and these parameters are incorrect if the workspace's instrument parameters you trying to reduce differ from the recent one.
This causes reduction suddenly stop working if recent instrument parameters were changed
Change History
comment:3 Changed 6 years ago by Alex Buts
- Status changed from assigned to inprogress
Re #10708 Advances in update_defaults_from_instrument and unit test
Also attempt to use it (not yet verified properly)
Changeset: 4fe89ddb6fb474b05ca9502a5f98ebb1aa6636c3
comment:5 Changed 6 years ago by Alex Buts
Re #10708 One more unit test for changes which seems sort thing out
Changeset: 45652bea5ac7878e9b1add5ec04e8c291515eab9
comment:6 Changed 6 years ago by Alex Buts
Re #10708 missing parameters in some currently actual IDF-s
Changeset: 3715ade4bd0abd50d5d2214e387c0b16aa591206
comment:7 Changed 6 years ago by Alex Buts
Re #10708 Something works bug looks dodgy.
needs further thinking
Changeset: 4da28e50ae4ed17bea28d310f6e504eb241a17ec
comment:8 Changed 6 years ago by Alex Buts
Re #10708 Better handling properties from workspace
Changeset: 813d2279a89a39770f6965a1059231d8c03cb862
comment:9 Changed 6 years ago by Alex Buts
Re #10708 LoadParamFromWS have been hopefully fixed
Changeset: 5bce9f319863dd898a4a25a9fecaa6817c50c4bc
comment:10 Changed 6 years ago by Alex Buts
Re #10708 Minor comments
Changeset: 6e517d54e009eaea79f55555f544139c2afea136
comment:11 Changed 6 years ago by Alex Buts
Re #10708 Minor changes to system tests, illustrating fixing behavior
(no test files or test parameters is modified)
Changeset: 3ae4cb59f546144e1e001dc6e52a2c8a8f115cbb
comment:12 Changed 6 years ago by Alex Buts
Re #10708 Returned to initial presentation of external properties
for MAPS. All works.
Changeset: e7b7dae74ece37d8a57add1413aff3b01b66bb40
comment:13 Changed 6 years ago by Alex Buts
Re #10708 Fixed MonovanIntegrationRange
Changeset: 56b860a0618c002fa12b354538e2d07657a9717b
comment:14 Changed 6 years ago by Alex Buts
Re #10708 Changes confirming that abs_units_van_integration_range
is interpreted correctly now.
Changeset: 359ddfdebd2f5d2be89fcbba6051517971c41080
comment:15 Changed 6 years ago by Alex Buts
- Status changed from inprogress to verify
- Resolution set to fixed
The changes are both in Mantid and System tests folders.
This was a nasty bug, which was very difficult to spot but I've heard numerous complains from number of IS.
The changes to reduction interface allowed to identify and fix it.
Hopefully old reduction scripts will continue to work with old data now.
The proof is in system tests for LET -- new LET IDF has different monitor number from the one used for measuring the sample.
Correct monitor number is loaded and used due to these changes.
The changes to the script appear to be much more complicated then I would assume, but as the interface is separated from the reduction it was easy unit test and introduce the changes.
Also minor bug (probably recently introduced while separating interface) when absolute uints integration range was not interpreted correctly has been fixed. (monovan abs units conversion parameter was changed due to this in system tests and it is obvious in the tests that the value of this parameter is correct)
Proof of correctness of these changes -- system tests.
comment:16 Changed 6 years ago by Lottie Greenwood
- Status changed from verify to verifying
- Tester set to Lottie Greenwood
comment:17 Changed 6 years ago by Lottie Greenwood
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/10708_InstrParFromWS'
Full changeset: 77039e4aa2069af64eeb90d5515ba20026e850cc
comment:18 Changed 6 years ago by Lottie Greenwood
Merge remote-tracking branch 'origin/bugfix/10708_InstrParFromWS'
Full changeset: 722673f5c49827b4f57dcbe53be7a8fd0f6433c9
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11550
Re #10708 Method to update instrument parameters from workspace
and unit test to verify it
Changeset: 54d3f77660670c172044fc72e37421268a5f9e06