Ticket #10709 (closed: invalid)

Opened 6 years ago

Last modified 5 years ago

IDR throws exception if facility is SNS

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: borreguero@… Blocked By:
Blocking: Tester: Nick Draper

Description

Since BASIS IDFs use a different naming convention the current way of loading them to get instrument properties does not work.

The simplest fix is to have at least one BASIS IDF named BASIS_Definition.xml.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Cc borreguero@… added

comment:2 Changed 6 years ago by Jose Borreguero

BASIS users are not supposed to use IDR, so I think it is a good behavior if the interface throws and exception.

comment:3 Changed 6 years ago by Dan Nixon

Do VISION users use it? It would also be broken for them.

comment:4 Changed 6 years ago by Jose Borreguero

No, they don't use it either. There is talk of creating a unified indirect reduction workflow for SNS instruments. It would be the analogous to the existing "DGSreduction" tools that are applied to direct instruments. Thus, I don't think the Indirect Reduction interface will ever be used with instruments of SNS.

comment:5 Changed 6 years ago by Dan Nixon

  • Owner set to Dan Nixon
  • Status changed from new to assigned

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to verify
  • Resolution set to invalid

This was fixed in another ticket where this interface was fixed to ISIS instruments.

comment:7 Changed 6 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.4

comment:8 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:9 Changed 6 years ago by Nick Draper

  • Status changed from verifying to closed

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11551

Note: See TracTickets for help on using tickets.