Ticket #10739 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

LoadGSASInstrumentFile fails to load some instrument parameter files

Reported by: Raquel Alvarez Banos Owned by: Raquel Alvarez Banos
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

LoadGSASInstrumentFile expects an instrument file with a three-line header per bank. When this is not the case, the parameters are not loaded correctly.

Attachments

hrpd.prm (2.2 KB) - added by Raquel Alvarez Banos 6 years ago.

Change History

Changed 6 years ago by Raquel Alvarez Banos

comment:1 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Raquel Alvarez Banos

For tester:

comment:4 Changed 6 years ago by Raquel Alvarez Banos

Re #10739 Update LoadGsasInstrumentFile to load files correctly

Changeset: c6dbd3be3769d057528b878ae42f0dfb40d713b9

comment:5 Changed 6 years ago by Raquel Alvarez Banos

Re #10739 fixing doxygen warning

Changeset: 76159f1a782101f4f7beb6bcadad45883795e694

comment:6 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:8 Changed 6 years ago by Federico M Pouzols

This ticket will also need a new 'checkbuild'.

comment:9 Changed 6 years ago by Raquel Alvarez Banos

Should be ready to test again.

comment:10 Changed 6 years ago by Federico M Pouzols

I works well.

I just have one question: is this 'hrpd.prm' tricky example worth a new/expanded test in LoadGSASInstrumentFileTest?

comment:11 Changed 6 years ago by Raquel Alvarez Banos

Re #10739 Updating unit test

Changeset: 5001bdcd63f60c7c5caef46a8e43843653dd5dfb

comment:12 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

All is well and tests pass.

comment:13 Changed 6 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/bugfix/10739_generalise_LoadGSASInstrumentFile'

Full changeset: 9fc49bbf8961e37307f6bbb8d27cdd5497536870

comment:14 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11581

Note: See TracTickets for help on using tickets.