Ticket #10740 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Crash in loading pv plugins on Ubuntu if paraview.path is not set

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: blocker Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

The ParaView core is initialized in https://github.com/mantidproject/mantid/blob/master/Code/Mantid/Vates/VatesSimpleGui/ViewWidgets/src/MdViewerWidget.cpp#L257-L259 but if paraview.path is not set then this crashes Mantid.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Martyn Gigg

  • Status changed from assigned to inprogress

Avoid using an empty paraview.path.

It causes a segfault on Linux/OS X if it is empty. Refs #10740

Changeset: 119bb21731e1390a14224b2a6e0deff9a4c5c524

comment:3 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #99.

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:5 Changed 6 years ago by Harry Jeffery

Tested on Ubuntu 14.04

Before the changes, ManitdPlot crashes when attempting to show the VSI. After merging, I am able to load the VSI and use the default and quad view.

comment:6 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to verify
  • Tester Harry Jeffery deleted

comment:7 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

I'm testing this on windows

comment:8 Changed 6 years ago by Federico M Pouzols

Tested on Windows 7: it works well. The quad (and other) views seem to be fine.

comment:9 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

Merge pull request #99 from mantidproject/bugfix/10740_mdviewer_crash_linux

All seems fine, it was tested on Ubuntu and Windows 7

Full changeset: 922b8507735e76e37bdb0fb4d20232629d52c805

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11582

Note: See TracTickets for help on using tickets.